Let us not use pull requests as political footballs.

in steem •  last month

A lot of comments today over this pull request which appears to be a proposal to remove control of "all Steemit Inc. controlled accounts" from anyone at all, and lock their Steem permanently.

However, this is not at all what is happening.

People who don't look closely see "pull request" and think we're talking about a proposed change to the Steem code, but that isn't what this really is. It's a stupid publicity stunt, a misuse of Github, and pisses me off completely regardless of the value of removing Steemit Inc.'s control of the ninja-mined funds, which I'm taking no position on at the moment.

Frankly, I don't see a reason to; this isn't a legitimate proposal, it's just there to stir up trouble. A new fork was made under the steemdev account, which was newly created apparently for this purpose, and is unrelated to any existing active development. Then this pull request was created, not as a means of merging code into the forked repository, but simply as a feature request. The only code associated with the PR is the basic structure of a hardfork. (Edit: this is incorrect. There is some half-baked code in there which Github was not showing me for some reason. It's still not appropriately complete for a PR.)

The author apparently would really like someone to come along and make this code change for him, and in order to get it more publicity he's made a phony "pull request" to a phony repository to imply that this might be something that will actually happen. That seems to have worked; there are plenty of people who are taking the idea seriously, as if it is something the witnesses could decide or not to do.

However, there's no there there. Dropping this as a pull request with the code in place would have been daring. Dropping it as a pull request with nothing more than a vague request for a feature is nothing more than a stupid publicity stunt. It's no different than someone saying "I think we should fork out Steemit Inc." except that he's using the cachet of Github to make it seem like something more serious and practical is happening.

This is bullshit. The idea of the witnesses removing Steemit Inc.'s ninja-mined stake from Steem may or may not be worth considering, but this phony pull request has nothing whatsoever to do with it. Please do not take it seriously.

Discussion of blockchain priorities can happen all sorts of places, even on Github, where the appropriate place for it is as Issues raised in an active repository. Pull requests are not appropriate places for spitballing new features that have no spec and no code; they're there to propose the adoption of complete code changes. Using them as political footballs just makes the development process more difficult.

Steem.png

Authors get paid when people like you upvote their post.
If you enjoyed what you read here, create your account today and start earning FREE STEEM!
Sort Order:  

You’re right, but this is what happens when serious-but-half-baked pull requests are passed around. I assert it was a credible threat to their property.

So, moving forward, maybe an alternate dev team can take this example and actually do some project management before dropping a bombshell pull request.

Thank you for calling this out. I was about to say something along these lines in various chats (well basically that it shouldn't even be taken seriously), but I think I'll just point people here.

·

However, one thing I'd point out is that having code ready makes it closer to reality. So it isn't exactly the same as just spitballing an idea. You'd think there's already some discussion behind the scenes leading up to this PR.

·
·

After rereading, you seem to suggest there's no code. But it's there: https://github.com/steemdev/steem/pull/1/files

·
·

There is no code. If there was code I would be fine with it.

The only code in the PR is the "if hardfork = 21" boilerplate, which shouldn't go in until the end anyway.

·
·
·

Update owner authorities? Looks like that would lock those accounts up?

·
·
·
·

That was not included when I started writing the post.

·
·
·
·
·

Oh :). Timing issues when looking.... Lol.

·
·
·
·
·
·

Also this comment appears to have vanished:

wolfcomment.png

Weird stuff happening here.

·
·
·
·
·

There is only one commit:

https://github.com/steemdev/steem/commit/807d5e0e0aef8c6f940bd003fd8e7404d738138a

So you just missed it on your first code review. It’s ok, that happens.

Your overall point still stands. How could a random pull request move so much stake? All we can do is speculate.

·
·
·
·
·
·

I guarantee I did not miss a giant swath of code like that on my first look, despite the commit history. I don't understand it, but it definitely was not there. There was hardly anything there.

·
·
·
·
·
·
·

I reviewed the code (it was there) and commented yesterday. Then my comment was deleted. So I don’t know what to tell you. 😂

Why you mention me?

I have nothing to do with that pull request, also I am pro Steemit, Steem.

And I have my own opinion about steemit moving their stake.

"This is also a really great strategic move to secure future growth and development, take the role as market maker/taker with their stake on the exchanges. They partnered with some folks that know the tricks of that game. That way they can multiply their revenue streams, and give more room and breath to the community, and when they see fit, support them from the sidelines."

·

Cause I'm an idiot today, apparently. I apologize and I've removed it.

To listen to the audio version of this article click on the play image.

Brought to you by @tts. If you find it useful please consider upvoting this reply.

Aren't people on all sides making too much of this? What's the link between jnordberg on Github and @nokodemion? Nordberg, an active developer known as @almost-digital here, simply made a pull request to his own repository, while acknowledging that it wasn't complete. Where did he propose to use it?

·

I honestly have no idea why I got noko confused in here. I feel totally stupid for that. I apologized above and removed it.

Aren't people on all sides making too much of this?

Probably. Steem.

simply made a pull request to his own repository

Well, no, he (presumably) created a new user called "steemdev" and then made a PR into that repository using his own user account to make it look like it was a full merge into an active project.

If the fork was in jnordberg and the PR was a partial commit into the jnordberg fork and he had merged it in and moved on with the next steps to making it a fully-fledged feature, that would have been normal. I have a hard time coming up with a legitimate reason for presenting it as a third-party PR into a repository owned by a generic Steem-named account.

(Then again, I'm clearly not having a good day here.)

It's really funny the ramblings of people based on this...

They needed money to fund shit. They chose to "ninja mine" it rather than do an ICO, since ICO's have been getting pretty hassled by the FEDs. If they had done an open mining there was a chance some crazy would have become a future whale on here while they were trying to get their stake to fund the place. You can hate it all you want, but it's no time to cut the legs off the horse when he's not even out of the stables.

Hi @tcpolymath!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your UA account score is currently 4.733 which ranks you at #1485 across all Steem accounts.
Your rank has not changed in the last three days.

In our last Algorithmic Curation Round, consisting of 217 contributions, your post is ranked at #18.

Evaluation of your UA score:
  • Some people are already following you, keep going!
  • The readers appreciate your great work!
  • Good user engagement!

Feel free to join our @steem-ua Discord server

This post has been included in the latest edition of SOS Daily News - a digest of all you need to know about the State of Steem.



Seeing this 2 days after gives perspective and also reflection of the consequences of what I agree to be not well thought out or even damaging actions. Seeing the actions of Steemit is a reminder of cause and effect and hope it demonstrates all of the issues we need to deal with as a community.

Posted using Partiko iOS