You are viewing a single comment's thread from:
RE: Busy - 1 new feature and 6 bug fixes - edit old posts, powerdown, voting value, reblogged_by, etc
- Good article, you could improve it by including some code samples.
- Please use pull requests links when possible, this commit above is not what was merged, this was.
- The fix for editing posts older than 7 days was merged last year! Please submit your articles within 2 weeks or the merger.
- Do try to include comments in the code, this will help the next developer or anyone looking at the code.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Hi @helo, thank you so much for your review and comments. Since this was my first dev post, I may have missed something you mentioned :) I fixed the wrong link. Thanks again!
Actually I also have some questions
The project isn't mine, so I wanted to (and probably should) follow their comment practice. Maybe because people can make a longer comment in the github commit/PR message, there were almost no comments in the original code. Thus, I wanted to follow their practice. Is this okay and perhaps more desirable? or should I still make comments in the code for utopian evaluation?
It seems that I tried to gather too much commits :) and one is expired for the evaluation. Is there any minimum num of commits for acceptance? The guideline says single commit isn't acceptable but no information about how many. Is it okay from 2? :) Or 1 is acceptable as well? One problem is sometimes PO doesn't merge quick. Actually that's why one is expired while I was waiting for others to be merged. So in the worst case, I may need to submit just a single commit if late commit (with not late commit) isn't acceptable.
Thank you for your review, @helo! Keep up the good work!