Busy - 1 new feature and 6 bug fixes - edit old posts, powerdown, voting value, reblogged_by, etc
Repository
https://github.com/busyorg/busy
1 new feature and 6 fixes for Busy
Note: I'm not a Busy employee :)
New Features
Edit posts older than 7 days
On Busy, editing old posts were still impossible even after HF20 for a long time. I enabled the edit function.
Bug Fixes
Fix powerdown amount
- Voting value is negative
- Powerdown amount is more than current SP, which is impossible.
This bug is due to the floor operation in the calculation of weekly powerdown amount, as explained in details in https://github.com/steemit/steem/issues/3237 Due to this, the entire powerdown may take 14 weeks. Thus when calculating 14-week powerdown amount, it should be at most the remaining withdrawal.
While I fixed that bug at steemd level, until the fix is applied in production, any client (e.g., busy) should user their own fix. Thus, I made the fix.
- After the fix is applied, voting value and powerdown amount (0 SP since it's 11 vests) are shown correctly.
Fix voting value
As explained in the above, Powerdown may actually take 14 weeks. Due to this bug, voting value for such users was incorrect, e.g., negative.
Fix reblogged by
Busy.org: my feed (rosatravels isn't my following)
Busy.org used post.first_reblogged_by which was always null. `post.reblogged_by' should be used, as in steemit.com https://github.com/steemit/condenser/blob/7430aca58ae9f86e501f52e3cf8dba5efc9fe3e0/src/app/components/cards/PostSummary.jsx#L70
After the fix
Fix relative url
A relative url, e.g., /@blockchainstudio/instant-undelegation-restoring-continuity doesn't work on Busy (It works on Steemit, Steempeak, etc).
Fix incorrect voting power
Vote value was shown incorrectly for users who hadn't voted for a while. This was due to the wrong calculation of VP regeneration for such users.
Fix incorrect total shares
SP being powered down shouldn't be included in the shares for voting power. Busy included it, so voting power looked much higher than the actual.
Commits
Edit posts older than 7 days
- Commit 1eed349
- Enable editing old posts.
Fix powerdown amount
- Commit 1afae98
- Fix powerdown amount for 14th-week powerdown.
Fix reblogged by
- Commit fb720cc
- Show "reblogged by" for reblogged posts in feed.
Fix relative url
- Commit 84db306
- Fix relative url problem
- Commit 9989ff2
- Remove busy.org hardcoding
Fix incorrect voting power
- Commit 0f5a69c
- Fix incorrect voting power for users who haven't voted for a while.
Fix incorrect total shares
- Commit 0f5a69c
- Fix incorrect total shares for users powering down
Fix voting value
- Commit 1afae98
- Fix 14 week powerdown voting value
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
[utopian-moderator]
Hi @helo, thank you so much for your review and comments. Since this was my first dev post, I may have missed something you mentioned :) I fixed the wrong link. Thanks again!
Actually I also have some questions
The project isn't mine, so I wanted to (and probably should) follow their comment practice. Maybe because people can make a longer comment in the github commit/PR message, there were almost no comments in the original code. Thus, I wanted to follow their practice. Is this okay and perhaps more desirable? or should I still make comments in the code for utopian evaluation?
It seems that I tried to gather too much commits :) and one is expired for the evaluation. Is there any minimum num of commits for acceptance? The guideline says single commit isn't acceptable but no information about how many. Is it okay from 2? :) Or 1 is acceptable as well? One problem is sometimes PO doesn't merge quick. Actually that's why one is expired while I was waiting for others to be merged. So in the worst case, I may need to submit just a single commit if late commit (with not late commit) isn't acceptable.
Thank you for your review, @helo! Keep up the good work!
In Korean: 그동안 busy수정했던 것을 일부ㅎㅎ 모음입니다. 너무 많아져서 두번으로 나누려고 합니다. 일부는 이미 반영이 됐고 일부는 따로 글도 써드릴 계획인데 https://staging.busy.org로 접속하시면 됩니다.
ps. 정작 busy는 오늘 또 엄청 불안정하네요. 아예 접속이 안되는 경우도 많고. 알람이 정상동작하지 않는듯ㅠㅠ 제 탓은 아닙니다ㅎㅎ 대부분은 아직 개발버전에만 적용되어있습니다.
ps2. ㅠㅠ 리뷰를 보니 merge된지 14일 이내의 것만 반영되나보군요. 사실 어렴풋이 기억하고는 있었는데 여러개 submit하면 최근것만 최신이면 되지 않을까 했는데 앞으로는 너무 모을 필요없이 몇개모이면 그냥 제출 해야겠습니다.
오늘따라 busy가 엄청 느리고 불안정하네요. 지금 서버 작업 중이라서 그런 걸까요? ㅎㅎ
busy는 스테이징 서버가 따로 있군요. 하지만 스테이징 서버도 바라보는 서버는 메인넷이네요.
좀전에 글 올렸는데 알림서버 버그때문에 그랬다고 하네요. 아예 일시적으로 기능을 빼버린 상황입니다ㅠㅠ
busy에서 알림기능이 없으니 댓글확인이 불편하네요.
곰돌이가 @anpigon님의 소중한 댓글에 $0.019을 보팅해서 $0.004을 살려드리고 가요. 곰돌이가 지금까지 총 2817번 $34.425을 보팅해서 $35.049을 구했습니다. @gomdory 곰도뤼~
짱짱맨 호출에 응답하여 보팅하였습니다.
Hi @blockchainstudio!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server
nTOPAZ 소개 및 간단한 퀴즈 이벤트 (최대 $1.25 👍)
퀴즈 참여 감사합니다 😊
Hey, @blockchainstudio!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!