You are viewing a single comment's thread from:

RE: Busy - 1 new feature and 6 bug fixes - edit old posts, powerdown, voting value, reblogged_by, etc

in #utopian-io6 years ago (edited)

Hi @helo, thank you so much for your review and comments. Since this was my first dev post, I may have missed something you mentioned :) I fixed the wrong link. Thanks again!

Actually I also have some questions

  1. comments in the code.
    The project isn't mine, so I wanted to (and probably should) follow their comment practice. Maybe because people can make a longer comment in the github commit/PR message, there were almost no comments in the original code. Thus, I wanted to follow their practice. Is this okay and perhaps more desirable? or should I still make comments in the code for utopian evaluation?
  2. minimum num of commits?
    It seems that I tried to gather too much commits :) and one is expired for the evaluation. Is there any minimum num of commits for acceptance? The guideline says single commit isn't acceptable but no information about how many. Is it okay from 2? :) Or 1 is acceptable as well? One problem is sometimes PO doesn't merge quick. Actually that's why one is expired while I was waiting for others to be merged. So in the worst case, I may need to submit just a single commit if late commit (with not late commit) isn't acceptable.

Coin Marketplace

STEEM 0.17
TRX 0.13
JST 0.027
BTC 60596.21
ETH 2611.46
USDT 1.00
SBD 2.64