[steemwallet] show powerdown amount + clarification of "master password" vs "master key"

in #utopian-io5 years ago (edited)

Repository

https://github.com/steemit/wallet

Let me first thank @steemitblog and @roadscape and other Steemit employees.

I'm very happy to be mentioned as an MVP contributor by @steemitblog in Downvotes Added, Community Contributions, Bug Fixes
mvp-blockchainstudio.png

Thanks a lot! I'll keep contributing :) Special thanks to @roadscape who is always kind on GH to contributors. I saw many community PRs have been merged recently, and @steemitblog mentions those contributions. This is a small but really big and important change.

New Feature: show powerdown amount

Previously the wallet only showed the powerdown schedule.

Now it also shows the powerdown amount.

Note that "~" is to indicate that it's approximate, since the powerdown amount is based on VEST not SP.

I also thought about adding an additional row in the "STEEM POWER" section, but it may require to add some message (like delegation information) and then translation is also needed which might be too much. So I've utilized the current powerdown schedule information area.

Part of Codes

This is the powerdown amount calculation including VEST to SP conversion.

I also simplified the check of powerdown.

Previously, powerdown was checked with Date(account.get('next_vesting_withdrawal') + 'Z').getTime() > Date.now();, which I don't think the best way.

Since we now need to calculate the powerdown amount, that check was simplified and unified.

Benefits

  • Hacking prevention: Considering the fact that the powerdown can be initiated by a hacker, the more detailed is the better.
  • Mistake prevention: It also prevents the wrong amount of powerdown by mistake.

Bug Fix - master password instead of master key

Previously, it says "The owner key is the master key for the account and is required to change the other keys."

But the term "master key" can be quite confusing. Users may be confused with the master password, which is totally different.

The term "master key" should be avoided.

Master password isn't a key of the PKI (Public Key Infrastructure) system. In that sense, it isn't a "key." So, the term "master key" shouldn't be used.

Now, it doesn't use "master key."

If you're interested in more details on keys and password, my tutorial post Owner Key vs Master Password / Offline Private Key Derivation from Master Password / Public Key Derivation from Private Key will be helpful.

GitHub Account

https://github.com/economicstudio

Sort:  
  • Great article with big impact, images, code sample and explanation of coding choices.
  • The code is very neat, and could have used more comments
  • Good job getting it merged and clearing up the wording as well.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Hi @helo, thank you for your reviews. While I followed their comment style, next time I'll try to add more. Thanks a lot again!

Thank you for your review, @helo! Keep up the good work!

Korean: steemitblog는 참고하시는 분이 많으셔서 이미 많이 알고 계시고 또 축하해주신 분들도 계셔서 감사합니다. 관련내용은 따로 포스팅하겠습니다.

  1. 오늘자 공지에 올라온 것 중 파워다운 금액보여주기가 제가 한겁니다. 이전에 busy와 esteem에도 제가 추가하기도 했습니다.

  2. 추가로 이건 어제 공지에 올라온 건데 간단한 것이지만 master key라는 표현은 쓰지 않는 것이 좋습니다. key를 pki(공개키암호시스템)에서 private key개념으로 생각하신다면 안좋은 정도가 아니라 잘못된 것이기도 합니다. 대응되는 public key라는 것이 없기 때문이지요. master password는 다른 키들을 생성하는 seed (씨앗) 개념입니다. 해당 부분도 수정요청해서 수정되었습니다.

다운보팅 생긴건 당연히 제가 한게 아니고. 정말 아 누구 아이디어인지 그렇게 바로 옆에 붙이는게. 물론 다행히 확인창이 한번 떠서 실수로 할 가능성은 없겠지만. 스팀잇 회사 내부 인력 리소스가 얼마나 부족한지 여실히 보여주는 사례인 것 같아 안타깝기도 합니다. 제가 고쳐보려다 이게 3군데에서 조금씩 다르게 보여지다보니 생각보다 여백 맞추는게 쉽지 않더군요. 특히 제가 stylesheet이런 거 이제 잘 모릅니다. 유저들 불만이 많으니 고치면 바로 반영해줄 것 같은데 능력자분들 이기회에 스팀지갑 공식 컨트리뷰터 되세요ㅎㅎ

Hi @blockchainstudio!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server

Hey, @blockchainstudio!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Coin Marketplace

STEEM 0.18
TRX 0.14
JST 0.029
BTC 57956.22
ETH 3126.99
USDT 1.00
SBD 2.45