Update on Bounty - Splitting Blog and Resteem into Separate Tabs

in #bounty7 years ago

In November, I posted this $50 SBD bounty to split the "Blog" tab into separate "Blog" and "Resteemed" tabs.

@bitcoiner took up the challenge, and submitted a pull-request under GitHub Issue 616. I was very happy to see the feature developed so quickly, but unfortunately the change ran into some hurdles..

It turned out that the way the blockchain API was written, splitting the "Blog" into "Blog" and "Resteem" caused an issue with the data being returned, so that the tabs did not show new data correctly when scrolling down.

@bitcoiner opened steem GitHub issue 581 to update the blockchain to return the "Blog" and "Resteem" data separately (so the scrolling would work). After the issue sat for some time, he impressively did the work himself and submitted a pull request to update the steem blockchain!!

I was fairly sure that after all of this, we would finally have our Blog and Resteem tabs, but in the end - Steemit decided to implement the feature in a different way:

Rather than splitting Blog into two tabs we decided to add some more filters to Blog page so users would be able to filter posts by author (including blog's owner) and by tag.

Unfortunately since the bounty required that the change to be added to the live site, the official conditions of the bounty will not be met.

I talked with @bitcoiner and even though the official conditions were not met, we decided that awarding him $30 of the $50 SBD seemed fair.

$30 SBD has been transferred to @bitcoiner:

I hope everyone agrees with the decision to reward part of the bounty, even though the conditions were not fully met. IMO, @bitcoiner put in a ton of work, and earned it - even though we ultimately did not get the feature we had been hoping for.

I am looking forward to the change that Steemit proposed being implemented, so that we will finally have a way to filter out "Blogged" and "Resteemed" content :-)


Reminder to vote for witnesses:
https://steemit.com/~witnesses
If you aren't sure who to vote for, check out this Witness Voting Guide!

Sort:  

Thanks for the token of appreciation! It was a really good learning experience diving into the steemd backend code and tinkering around with it. Even though my solution wasn't ultimately deployed, Steemit Inc.'s solution looks fantastic and is definitely something to look forward to! Coincidentally, I was already at work on this a day or two before you had announced the bounty, so I wasn't really expecting it. Nevertheless, it was a really nice touch and I think it's very generous of you to incentivize community development work! Thanks again and @timcliff for witness!

This was a great way to handle it @timcliff - Thank you for the efforts @bitcoiner

Although the filter will be nice. Separate tabs is much preferred, shame @bitcoiner's work won't be put to use by steemit

I agree. I'd much rather have a separate tab than just more filters. This is strictly about separating your own content from content that is not yours in a clear and organized manner.

Why is it so hard for the Steemit Inc. dev team to listen to what users actually want?

well deserved for so much work.

They deserved the SBD they worked hard enough for it :)

I would write code for steem, but I have never gotten a response.
Like, I need to know who has to be notified of a change going to occur, and who is in charge of structure design. Who do I talk to about how a change will work in the current structure?

I won't write anything that will just sit there.

Here is some info on the technical side.
https://steemit.com/steemit/@timcliff/instructions-for-installing-a-steemit-com-instance-for-developers-interested-in-working-on-changes-to-steemit-com

All of the changes are submitted via the GitHub repository via pull requests.
https://github.com/steemit/steemit.com/

If you are interested in working on things, you should email [email protected]. (He is the project manager.)

I'm also happy to help if you have any questions.

Thanks you

I had questions and enthusiasm... but, they went badly unanswered, so interest has waned.

Several people wanted to work on multiple documents at a time. Does Steemit.com store the draft on the server, or in some way on the person's computer? Does Steemit.com want a feature as such? Or do the want to avoid it because of database bloat, or needless complexity?

steemit.com finds the first image in the post (or in H1) and then runs it through a process to make the thumbnail. Many people would like to select a thumbnail, because they do not want to use the first image. It would also be nice for sites like steemimg to provide a link to the thumbnail stored there so as to avoid bandwidth usage. I believe this would require a change to the block chain, does it?

I'm not sure what you mean as far as documents. All of the code changes are managed by GitHub pull requests. If you read up on GitHub branches, pull requests, and merging - that should give you an idea of how it works.

There will be changes to the images soon, in that users will be uploading directly to steemit.com (instead of using third party sites like steemimg). As far as selecting which image to use as the thumbnail - I think that is a highly desired feature.

The image logic shouldn't need a blockchain change. The blockchain will just store the links to the images (like it does currently). Steemit will be hosting the images, and the Steemit UI is what controls the thumbnail. An update may need to be made to how the data gets stored in the json_metadata of the post (in the blockchain) - but I am pretty sure this would not be a change to the actual blockchain.

https://steemd.com/tx/2cf51fe18bfc502fd7b378092fb70886c9a83ff1
As you can see, on this view of the post, there is no field for a thumbnail.
It should be just under title, which, now, I am fairly certain requires a change to the block chain.
It also looks like it can be added to the json_metadata as another tag, and this would not require a change to the block chain. That is, if the json_metadata is not dynamically built.

I can see three solid ways to do this, but it requires a lot of changes, one to each part of the system.

And, like I said, coordinating with people is the hard part.
Who is @sneak? And how is the best way to not send a c,old letter to his spam folder?

There is actually an open GitHub issue for the "choosing a thumbnail" request, with some discussion in it :)
https://github.com/steemit/steemit.com/issues/359

@sneak is the project manager for the Steemit dev team. If you send him an email along the lines of "I'm interested in working on pull requests for Steemit" he will not ignore you :) Plus, he actually reads all emails from the people in the community, and has said publicly for people to contact him if they are interested in discussing such things.

GitHub is a non-issue to me, all of my problems are with humans. I could completely rebuild steem, fix all the bugxs... and no one would know. It would just sit there on GitHub.

I do not know the header structure of steem. I am pretty sure that a steemit.com looks at the text in each post and determines the image to resize into a thumbnail.
The links are in the body of the post. I am suggesting that the link to the thumbnail should be stored in the same place that the title of the post is stored. It is a simple change, but unless it is already a field in the block, then it requires a change to the block chain.

Here's an example of a post in the blockchain. You can see the image info in json_metadata. You'd have to look at the Steemit.com code (on GitHub) to see how their logic for images works. (I'm not familiar with that part of the code.)
https://steemd.com/tx/2cf51fe18bfc502fd7b378092fb70886c9a83ff1

I've submitted 3 pull-requests to GitHub. Two of them were accepted, and one was not. I don't think that the changes just 'sitting there' is a problem - but it would be good to coordinate with @sneak and the dev team for any changes you are planning to work on. (There is no use putting in the effort if they aren't going to accept your change, or they want it done in a certain way that is not the same as how you were planning to do it.)

Dealing with the humans is part of the software dev process though, as I'm sure you know ;)

Sorry, just got what you were saying about the drafts.. Yeah, that would be an awesome feature too! You should email @sneak if you are interested in working on those things. Ultimately it would be on you to develop the change and ensure you were following the coding conventions of the project, but he should at least be able to let you know if what you are working on is something they are interested in - and point you in the right direction.

This post has been ranked within the top 25 most undervalued posts in the first half of Jan 27. We estimate that this post is undervalued by $14.24 as compared to a scenario in which every voter had an equal say.

See the full rankings and details in The Daily Tribune: Jan 27 - Part I. You can also read about some of our methodology, data analysis and technical details in our initial post.

If you are the author and would prefer not to receive these comments, simply reply "Stop" to this comment.

Coin Marketplace

STEEM 0.33
TRX 0.11
JST 0.034
BTC 66407.27
ETH 3219.07
USDT 1.00
SBD 4.34