RE: [Bug fix] Incorrect vote value due to incorrect voting power
Thanks for your contribution @blockchainstudio
I can see this issue is present both on busy.org and staging.busy.org (they seem to be on the same version, but wanted to check anyway) if you didn't already know busy.org provides a version number within their settings area, including this in your post would only provide further value to your reports :)
It's great to see that you've added an issue on GitHub and even a pull request to resolve the issue, did you know that you can score higher with Utopian if you wait until the issue has been acknowledged by the project owner before submitting your contribution?
Overall, the issue was easy to understand and as your steps only required one line, no trouble here. With that said I would have liked to have seen so more detail in the explanation surrounding the issue, for example, within your fix you mentioned that you need to make adjustments to get the actual voting power, how did it get to a point where it would be calculated as zero? Also, what would be the cause that other accounts would be affected by this too? Are all accounts currently affected by this? I believe that providing this information you would be able to provide more value to the readers of this report, or maybe I'm just interested to know ;)
Overall, it's great to see that you've both identified the issue and provided a potential fix through a pull request. I see that you contribute to busy quite a lot? Have you had a chance to look through any of the other projects on our whitelist?
Thanks again for your contribution and I apologize for so many questions haha, look for your contributions in the future.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Hi @tobias-g, thank you so much for your review and comment.
Actually I didn't know that and thanks a lot for this tip! Last time interestingly, it was merged before the review (by a different reviewer) even though I posted the same way :) But this time you came quite early :)
I'll post after the fix is merged next time. Thanks!
No problem :) Also, just so you know, you could potentially add bug fixes within the development category instead of in bugs-hunting. I would recommend this when you carry out larger, more complex fixes. I think in this case, with the number of additions made, this is perfect for the bug-hunting category. One to remember for the future :)
Thanks for the additional tip. Yes I actually know dev category and since this is simple as you mentioned, that's why I submitted as bug-hunting :)
Actually, I have a question. What if the bug is already reported but there is no fix and I made a fix. Then is it eligible for bug-hunting category?
In the scenario where a bug has already been reported and you make a fix, this would be a contribution that would fall under the development category. The main purpose of the bug-hunting category is for QA individuals to seek and report issues, however it's always great to see a little more added value to the project through a pull request :)
Thank you for your answer. That's what I expected. By the way, then if it's a simple bug fix, at least it can still be accepted under the dev category? Of course, I don't expect high score, but at least it'd be good to be accepted.
Yes, you can submit smaller bug fixes into development, just explain it well, the reasons it occurred and how you resolved it. As you say, you they may not always be high scores due to the amount of work required, but they're definitely valid contributions in that category.
Thanks! But it says on https://join.utopian.io/guidelines/
"Submissions should include a comprehensible commit history. Projects or updates submitted in a single commit will not be considered for potential reward."
Fortunately, I have a multiple commits, but I still wonder what's the exact rule. You know in some cases, one commit can be very critical.
Thank you for your review, @tobias-g! Keep up the good work!