Steeditor.app: Invalid permlink character error
Project Information
- Repository: https://github.com/jakipatryk/steeditor
- Project Name: Steeditor.app
- Publisher: @jakipatryk
A GitHub issue was created and the the issue was fixed by @jakipatryk in PR#90.
Expected behavior
Steeditor builds a permlink from the post title. However, not all characters are allowed in permlinks. Steeditor should allow any characters in the title and replace invalid permlink characters to form a working permlink from the title.
Actual behavior
Underscore (_) chars from the title are not allowed in the permlink and are not replaced. The comment broadcast call to SteemConnect returns code 500 with {"error":"server_error","error_description":"false: Invalid permlink character: _"} and Steeditor shows an error:
How to reproduce
Try to submit a post with underscores in the title, e.g.
Steemit replaces underscores with "-".
A similiar use case of replacing underscores with dashes could be found in an issue on the upstream library used to handle the permlink generation: https://github.com/pid/speakingurl/issues/103
{ custom:{'_': '-'} should do the trick, but I did not know how to insert this to steeditor here.
@jakipatryk implemented the fix with PR#90.
Environment
Chrome 69.0
Steeditor as live on https://steeditor.app on 18-10-09
Thanks for your contribution.
I think this is the first chance I've been able to review one of your contributions as I see a lot of them are about Python and I'm out of my depth there, but all in all, I see good quality contributions coming in so keep up the good work.
In terms of this contribution although the application caters to this fairly well I believe this provides value to the project as highlights an easy fix in an area that could cause confusion to the user. The contribution is well written and also provides value to external readers, this includes me who is currently building an application and I didn't know this is an issue.
As always it's great to see that you have reported on GitHub, would have been cool to see you add a fix in relation to the code (I know you mentioned it), but with that said you've took some good steps in suggesting possible solutions through researching where others have made this mistake too, so nice work on that and I like this approach.
Once again, thanks for your contribution. Keep up the good work!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @tobias-g!
So far this week you've reviewed 1 contributions. Keep up the good work!
Hi @stmdev!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server
Hey, @stmdev!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!
Congratulations @stmdev! You have completed the following achievement on the Steem blockchain and have been rewarded with new badge(s) :
Click on the badge to view your Board of Honor.
If you no longer want to receive notifications, reply to this comment with the word
STOPDo not miss the last post from @steemitboard: