You are viewing a single comment's thread from:

RE: Insteem is finally here. Rejoice. Application update and release to the play store. Download it while it is hot.

in #utopian-io5 years ago

Thank you very much for your contribution. I didn't know the Insteem app apart from esteem and parktio. But have to say that more competitions are good, at least for the steem community and steemians, we need more options.

  1. You have a few commented-out code, including XML template. In general, it is not a good idea to have commented out code, as this will make the codebase messy.
  2. What is 432000 magik number? you might want to define that as a constant.
  3. The checks such as result.user.reward_vesting_balance != "0.000000 VESTS" looks very unstable, you might expect unexpected zeros sometimes - which might break the code.
  4. At the level of such projects, I'd like to see some unit tests that cover your changes, at least to give some confidences.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thank you, I was actually before partriko but I suck as a promoter and in the middle lost the origonal app which was called steemer.

I'll think of better checks and make other suggested changes.

Thank you for your review, @justyy! Keep up the good work!

Coin Marketplace

STEEM 0.20
TRX 0.12
JST 0.028
BTC 64233.18
ETH 3491.62
USDT 1.00
SBD 2.54