RE: The Magic Frog: Estimated Rewards and Vote Weight Adjustment (Development Update)
Nice update!
Let's go for the review:
I think you could simplify
getCurators
using await / async.https://github.com/mktcode/the-magic-frog/commit/3cb8375bbdd4bf4c1bdcad2f6f94abf5fbadf0b4#diff-b19fa22add3de9cd0b98b05366479d92R288 => See best practice
https://github.com/mktcode/the-magic-frog/commit/3cb8375bbdd4bf4c1bdcad2f6f94abf5fbadf0b4#diff-b19fa22add3de9cd0b98b05366479d92R322 => It can be shortened. How about this?
return this.curators.findIndex(curator => curator.voter === this.user.account.name) !== -1;
https://github.com/mktcode/the-magic-frog/commit/3cb8375bbdd4bf4c1bdcad2f6f94abf5fbadf0b4#diff-b19fa22add3de9cd0b98b05366479d92R369 => See best practice
https://github.com/mktcode/the-magic-frog/commit/4ad4d8af2a3b80a748a6a84c0b1bf288897fc192#diff-95a142c4a0839a415d509d55ffbaa5d3R100 => How about this?
Math.min(100, this.voteWeight)
You're missing some french translations :D
https://github.com/mktcode/the-magic-frog/commit/794b15bbf32c3c164f6dd82441a4a0cbbd3adf4a#diff-b19fa22add3de9cd0b98b05366479d92R632 => See best practice and See best practice
A few hiccups in the javascript best practices but it's good! (May be add eslint :p)
See you.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Hey @gregory.latinier
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.
Contributing on Utopian
Learn how to contribute on our website.
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!