RE: Introducing Move Club - Get Rewarded for working out 👣

You are viewing a single comment's thread from:

RE: Introducing Move Club - Get Rewarded for working out 👣

View the full context

fel1xw (53)in #utopian-io • 6 years ago

Great project Sam,

I've added a workout to try things out and just discovered a small issue with the "min" (duration) value for the comment content you are generating. but reading through the comments here it looks like you will change this behavior anyway in the future. I already wanted to create a PR to fix this issue because it just looks like you are expecting a value at the "/post/comment" endpoint in your express route which is not given from the frontend.

I really like the way you are using the comments/metadata as the database. I'll save this idea for a future project. :)

If I can help you with something specific, don't hesitate to ask for help. It looks like some of your code can be improved in terms of readability and es6 features.

Cheers and keep the good work up!

6 years ago in #utopian-io by fel1xw (53)

Sort:

sambillingham (65) 6 years ago

hey.

Thanks for the note, have fixed the "min" duration now and will work on allowing customisation to the message in the next update.

I like the use of the metadata as it allows other interfaces to use this data if they wanted, reducing platform lock-in.

I would really appreciate if you have any ideas on how I can use ES6 features to improve the code. I won't take any offence at all, please feel free to point out anything that can be improved. I know there is a lot of features/patterns that I must be missing. I fell out of programming last year and with how fast things change there is a lot of areas I can improve on.

$0.00

1 vote

[-]

fel1xw (53) 6 years ago

Hey Sam,

thanks for your reply! I've seen that you changed that part. Great.

I've noticed you created issues in your repo. I just took one and created a pr based on this. It's something small, but I wanted to check out your repo structure. I'll possibly browse and "beautify" some files in the future.

Actually you/we should also think about to remove the login part/cookie generation in the backend (trust issues) and make it a frontend only thing (store token in localStorage) as @smartsteem is doing this in their frontend app (built with vue.js).

Cheers.

PS: To talk more into detail about future features that I could help you, could you reach me out at steem.chat? Or I just add you on discord.. :D

$0.00

[-]