You are viewing a single comment's thread from:
RE: [beem] one-time private key / wallet compatibility
Hi @blockchainstudio, beem is primarily a library where other tools build upon. beempy is one example but by far not the only one. Having transactionbuilder call print or asking for a key via getpass is no problem for beempy since it is a CLI anyway. However for non-CLI applications, bots, cronjobs, this would unexpectedly print things to stdout and block on getpass instead of raising an exception that can be handled on the higher-level code. beem/cli.py is IMO the right place to implement this great suggestion.
Hi @crokkon, thank you so much for your detailed comment and now I understand what you meant and fully agree with you! I misunderstood your comment like you meant the code itself may not work :)
One last comment is of course I also tried to change cli.py and thought it was the right place to change, but you know in that case, I basically need to change every command that may raise the exception, which was too much, so I took the bad design without thinking further :) But you and @holger80 are 100% right in this case. Thank you so much again and I'll close my PR.
Are you planing to make a PR in which cli.py is adapted? Please let me know, so that we both do not work for the same changes..
Thank you for contacting me. It seems you already have interest in doing it, then I think it's better for you to do it for efficiency (unless you want me to do it). What about the wallet compatibility? Are you interested in that too?