[eSteem Surfer][2.0.5] comments tab & delegation detail don't work + etc

in #utopian-io6 years ago (edited)

Project Information

This is a collection of 5 bugs for eSteem Surfer 2.0.5 that has been just released. I've submitted the issues acknowledged by PO and some of them are resolved by my PRs that's been merged, others are still open.

Expected behavior

  • Comments tab should show comments.
  • version number should be 2.0.5
  • Build process should work.
  • Delegation detail should work.
  • typo: SBD not SDB

Actual behavior

  • Comments tab shows nothing
  • (fixed) version number is still 2.0.4
  • (fixed) Build fails
  • Delegation detail should work.
  • (fixed) typo: SDB instead of SBD (both UI and some variable names :) I know this can happen. Happened in my codes before too!)

How to reproduce

  • Comments tab bug
    • Do the clean install then the default server is api.steemit.com
    • Pick any user
    • Click comments tab
  • Delegation detail
    • Pick any user who has delegated
    • Click the delegated amount
  • App version: 2.0.5
  • Operating system: MacOS / Win

Recording Of The Bug

  • Comments tab shows nothing

note that wrong ver number is now fixed

  • Delegation detail should work.

If clicked, a white blank page is shown, and no way to go back (Is there any keyboard shortcut for go back?)

https://github.com/esteemapp/esteem-surfer/blob/93599f413ca9c2c0920ec9fd28386837b22faaf1/app/components/Account.js#L1113

  • typo: SDB instead of SBD

Cause

Comments tab doesn't work with the official api.steemit.com, but works with other servers, which probably means it's using deprecated API. Similar problems happened in other apps recently. I informed this potential reason.

I also pointed out the code location for other bugs.

GitHub Account

https://github.com/economicstudio

Sort:  

Hi @blockchainstudio, thanks for making this contribution.

Good to see you focus your hunting lens on the esteem surfer.

I could reproduce the behaviors you described. Though these could have been split into separate posts since the issues are not related.

I love the detailed correspondence between you and the PO in all of the tickets you opened. I noticed that due to the collection of issues in a single post, you could only explain in detail one of the errors - the comment tab not loading - analysing what could have caused it.

The steps provided were easy to follow for each of the bug listed. I like the way you arranged the expected and actual behaviors. It made for a smooth read :)

I look forward to your future reports.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Hi @fego, thanks for your review and comments. You're right :) Even though I could have separated this collection into a couple of posts to claim more rewards :), I actually didn't want to, since the main reason of doing this is actually to help. I believe you also consider that and give better scores :) thanks again!

Thank you for your review, @fego! Keep up the good work!

In Korean: [잡담] 5위 증인으로부터 팔로우 받은(받아낸ㅎㅎ) 썰에서 소개시켜드린대로 esteem surfer https://github.com/esteemapp/esteem-surfer/releases 라는 5위 증인인 good-karma가 만들고 있는 스팀잇 데탑 클라이언트입니다. 제가 쓰진 않지만 partiko이전에 가장 많이 쓰였던 esteem이란 앱의 데탑버전일 것 같습니다. 데탑 클라이언트를 좋아해서 수고스럽게ㅎㅎ 설치하고 써봤는데 아직은 초기단계여서 그런지 아니면 새로버전업해서 그런지(원래 항상 뭘 바꾸면 버그가 생기기 쉽죠ㅎㅎ) 자잘한 버그가 많네요.

솔직히 다 사소한 것에 이 앱을 몇명이나 쓸까 싶어서 깃허브에만 리포트했음 됐지 굳이 유토피안 글을 써야하나 은근 이런 글도 포맷맞춰쓰는게 고역ㅠㅠ이라 안쓰려다 이런 앱도 있다 또 원하신다면 이렇게 버그 리포팅 유토피안 글은 결코 어렵지 않다는 것도 설명 드릴겸 써봅니다.

많은 버그를 수정하셨네요. 이제 feruzm님과 많이 친해졌겠어요. ㅋ

ㅎㅎ 딱히 그렇진 못한것 같고 그래도 오늘 보니 머지하나 또 해줬더라고요^^ 근데 진짜 앱이 좀 넘 그래서ㅋㅋ 앞으로 계속할지는. 오픈소스가 제법 많으니 참고해서 새로운 더 좋은 걸 많들어 주세요^^

곰돌이가 @anpigon님의 소중한 댓글에 $0.018을 보팅해서 $0.005을 살려드리고 가요. 곰돌이가 지금까지 총 2899번 $35.487을 보팅해서 $35.873을 구했습니다. @gomdory 곰도뤼~

이런글 항상 응원합니다
최고!

짱짱맨 호출에 응답하여 보팅하였습니다.

Hi @blockchainstudio!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server

Hey, @blockchainstudio!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Coin Marketplace

STEEM 0.18
TRX 0.16
JST 0.030
BTC 67724.53
ETH 2606.51
USDT 1.00
SBD 2.72