You are viewing a single comment's thread from:

RE: Finally Network - Dashboard, Hashtag filtering, fixes & more

in #utopian-io5 years ago

Thanks for the contribution, @sambillingham! Those are definitely some cool new features you've added!

Will (is) it be possible to filter by multiple hashtags? Also sucks that you had to remove resteems because they were breaking things. I'm pretty sure some people will find them useful, so it's good you are looking to bring them back in the future.

A small thing I was wondering about your code: it seems you have different JavaScript files for each theme, but sometimes they share code. Maybe you could move that to a utilities file, or something like that, to make your code more DRY.

Great work, and I'm really looking forward to seeing where this goes - I think it could become really big!


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thanks for the review Amos.

Will (is) it be possible to filter by multiple hashtags?

It's not possible right now. I plan on changing it to be an include & exclude list instead.

Also sucks that you had to remove resteems

Agreed. I should be able to bring them back it will just need some extra implementation. I didn't think about it before but on other platforms resteems only exist in the feed view and just point to the original content. I'm not sure sending to another 'website' is really what people would expect in the Finally scenario. I think I have a way to make it work.

Maybe you could move that to a utilities file, or something like that, to make your code more DRY.

Yeah thats the plan. It's certainly not that DRY right now. Cuplication that is clearly asking for issues later. I'm hoping to make most of the usual features (post loop, filters, displaying, prev/next etc) into utils that are re-used between all themes, makes sense right. Just wanted to kick start the project and not get too bogged down in optimisations out the gate.

Thanks for the continued support 🚀

Thank you for your review, @amosbastian!

So far this week you've reviewed 12 contributions. Keep up the good work!

Coin Marketplace

STEEM 0.30
TRX 0.14
JST 0.039
BTC 61845.76
ETH 3419.37
USDT 1.00
SBD 4.93