[SwapSteem] Fixed Footer Prevents Post Trade Call to Action From Being Clickable

in #utopian-io5 years ago

Project Information

Expected behavior

The call to action shown at the bottom to submit a trade should be clearable clickable or the page should have enough overflow to allow me to click this option easily.

Actual behavior

The footer shown the bottom of the page prevents the post-trade option from being clickable.

How to reproduce

  1. Select Post a Trade located with the navigation bar
  2. When on the post a trade form, select the following options: Ad Type: BUY, From: STEEM, Market: Fiat
  3. Note that the height of the form changes, now scroll to the bottom of the page and view the post-trade button.

Enviroment

  • Browser: Google Chrome (Version 71.0.3578.98 (Official Build) (64-bit))
  • Device: MacBook Pro (Retina, 15-inch, Late 2013)
  • Operating system: MacOS Mojave Version 10.14.1 (18B75)

Screenshot

The following screenshot shows this issue in more details when I have scrolled to the bottom of the page.

image

Note the green line at the bottom of the form, this is the post-trade button the page. This could not be scrolled to.

Issue & Resolution

In my personal option the easiest fix for this issue would be to remove the fixed on the footer to it only to display when a user reaches the bottom of the page, the goal here is not for a user to see who made the application, the goal should be to allow them to view and create trades, removing the fixed on the footer would resolve this issue and prevent any overlap.

Details surrounding the class I mean can be seen here:

image

If you choose to keep the footer the, this could also be resolved quickly by applying height: calc(100vh - 25px) on the main body of the page. This can be seen here:

image

Note I did not apply this to the box class as I assume this is shared through the side and I assume this is only one the problem areas due to the variable width based on the form size.

With the above said I think the table on the home page could also benefit from an adjustment to the footer.

GitHub Account

A link to my GitHub account can be found here:

The issue was reported here:

https://github.com/nirvanaitsolutions/swapsteem/issues/118

Since this report being added to GitHub, this issue has now been resolved.

Sort:  

Hi @tobias-g, thanks for making this contribution.

It appears to have been fixed and closed. The behavior is particularly strange considering an action button should be visible and as well clickable.

I like that you analysed and also proposed a fix. This is not surprising, considering you are very well versed in CSS. Your mastery is well known and talked about in the corners of Utopian. Good to have you share this.

I like the manner in which you described the expected and actual behaviors. Made the text easier to understand. So were the steps.

Thanks again for the contribution. I look forward to more of these :)

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Thanks for the review @fego :D

Thank you for your review, @fego! Keep up the good work!

Hi @tobias-g!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server

Hey, @tobias-g!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

This post has been included in the latest edition of SoS Daily News - a digest of all you need to know about the State of Steem.

Coin Marketplace

STEEM 0.29
TRX 0.12
JST 0.033
BTC 62559.43
ETH 3092.10
USDT 1.00
SBD 3.86