SteemPlus [3.1.0.1] Unable to vote via SteemPlus vote slider on Busy.org

in #utopian-io6 years ago

Project Information

Repository: https://github.com/stoodkev/SteemPlus/
Project Name: SteemPlus
Publisher: @stoodkev

Expected behavior

When selecting vote on a post and using the SteemPlus slider I should be able to vote successfully for a post.

Actual Behaviour

When I select vote on a post and submit the vote, the vote is not cast successfully.

Pre-Requisites

  • Vote Slider Value (for busy) should be enabled within settings.

Steps to reproduce

From a fresh install download SteemPlus here

  1. Complete the on-boarding flow and sign in via SteemConnect
  2. You will be redirected to Steemit.com (if you're already on the site, refresh to ensure the SteemPlus extension is working as expected).
  3. Go to Busy.org and go to your feed.
  4. Select a post and vote on that post using any vote weight.

Environment

  • Browser: Google Chrome Version 69.0.3497.100 (Official Build) (64-bit)
  • Device: MacBook Pro (Retina, 15-inch, Late 2013)
  • Operating system: MacOS HighSierra Version 10.13
  • Application Version of Testing: 3.1.0.1

Error & Resolution

The reason this particular issue is occurring is due to SteemConnect depreciation, it looks like this area of the code wasn't adjusted following the switchover in a previous release. In order to resolve this, the feature needs to be switched over similarly to other features. The reason I believe this is due to the following error:

vote_weight_slider_busy.js:158 Uncaught TypeError: sc2.vote is not a function
    at HTMLButtonElement.<anonymous> (vote_weight_slider_busy.js:158)
    at HTMLButtonElement.dispatch (jquery.js:1627)
    at HTMLButtonElement.q.handle (jquery.js:1589)

Recording of issue

The following video shows this issue in more detail:

Proof of work

My GitHub account: https://github.com/tobias-g1

The issue has been reported here:

https://github.com/stoodkev/SteemPlus/issues/168

Following this report, the project owner has now resolved this issue, this can be found within the following commit:

https://github.com/stoodkev/SteemPlus/commit/f7935fc51433415d2ced5276e3bc0a243908b31e

Sort:  

Hi @tobias-g, thanks for making this contribution.

I see the issue has been fixed, thanks to you pointing what exactly to look for.

Feedback:

  1. The title contains sufficient information, and follows the set Utopian bug post naming convention.
  2. The expected and actual behavior were properly explained. The discrepancy between the two behaviors could be spotted with ease.
  3. The steps provided were short and precise, and easy to follow.
  4. It was helpful of you to have provided an analysis of the probable cause and also pointing us in the direction where the error must have originated.

This adds significant value to the open source community, I look forward to your next contribution.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[[utopian-moderator]](https://join.utopian.io/

Thank you for your review, @fego!

So far this week you've reviewed 1 contributions. Keep up the good work!

Hi @tobias-g!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server

Hey, @tobias-g!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Coin Marketplace

STEEM 0.20
TRX 0.15
JST 0.029
BTC 63362.14
ETH 2592.64
USDT 1.00
SBD 2.80