[Debato] Unable to edit posts (redirected to localhost)

in #utopian-io6 years ago

Project Information

Expected behavior

A user should be able to edit a debate.

Actual behavior

When attempting to edit a debate you're directed to localhost and therefore unable to edit a debate.

How to reproduce

  1. Go to https://debato.org
  2. Create a debate
  3. Once created, click edit debate.
  4. Note that you're directed to localhost.

Enviroment

  • Browser: Google Chrome (Version 71.0.3578.98 (Official Build) (64-bit))
  • Device: MacBook Pro (Retina, 15-inch, Late 2013)
  • Operating system: MacOS Mojave Version 10.14.1 (18B75)

Issue & Resolution

The cause of the issue can be found here:

      if (info.author === user) {
        body += `<a class = "editlink" href='http://localhost/html/create?p=${activePost.permlink}'>edit</a>`;
      }

This issue could be resolved by removing http://localhost so the link becomes relative.

Recording Of The Bug

The following shows the issue in more detail:

feb-27-2019 18-46-25

GitHub Account

A link to my GitHub account can be found here:

https://github.com/tobias-g1

A link to the issue reported on GitHub can be found here:

https://github.com/samvanemelen/debato/issues/4

Since this report, the issue has been resolved in the following commit:

https://github.com/samvanemelen/debato/commit/6e2588bd9eb32a09424cafaf8f5a82c5e18cddbd

Sort:  

Hi @tobias-g, thanks for making this contribution.

I was unable to reproduce the bug. I was unable to create a debate after I logged in, could not find in the page the link with which to create new debates and then edit. Strange

I see the PO already fixed the supposed bug in the commit. Did the edit feature work for you after the fix?

Following your analysis, it appears it was a simple bug that required as well a simple fix. Good job :)

I look forward to more of your reports.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Thanks for the review :)

Yes, after the fix I tested again (on an existing debate) and it was resolved :)

Thank you for your review, @fego! Keep up the good work!

Hi, @tobias-g!

You just got a 1.09% upvote from SteemPlus!
To get higher upvotes, earn more SteemPlus Points (SPP). On your Steemit wallet, check your SPP balance and click on "How to earn SPP?" to find out all the ways to earn.
If you're not using SteemPlus yet, please check our last posts in here to see the many ways in which SteemPlus can improve your Steem experience on Steemit and Busy.

Hi @tobias-g!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server

Hey, @tobias-g!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Coin Marketplace

STEEM 0.19
TRX 0.15
JST 0.029
BTC 64349.20
ETH 2673.53
USDT 1.00
SBD 2.83