Steeditor.app: Community-field was restricted to lower-case chars only

Project Information

• Repository: https://github.com/jakipatryk/steeditor
• Project Name: Steeditor.app
• Publisher: @jakipatryk

A GitHub Issue was created:

• https://github.com/jakipatryk/steeditor/issues/72

The bug was confirmed and fixed by the project owner

Expected behavior

Originally expected behavior: The community field in the post's json_metadata is (from Steem-perspective) only required to be valid JSON, there is no restriction on characters or formats from the blockchain implementation: https://github.com/steemit/steem/blob/c6b865b6f27999cba38f3840151c8306f14f3371/libraries/protocol/steem_operations.cpp#L86

Actual behavior

Steeditor requires the community field to consist of lower case chars only and shows an error message when other chars are used.
While lower-case chars only is quite common for the community field across apps, not all apps do this. Actifit for example uses a list in the community field. The blockchain allows any content as long as the resulting json_metadata is valid JSON.

How to reproduce

Enter upper case or special chars in the community field

Corresponding check in the code:
https://github.com/jakipatryk/steeditor/blob/6911916e38eb7a8919e6a336def474d8e10dbeb8/src/app/editor/components/community-partial-form/community-partial-form.component.spec.ts#L31

Environment

• Browser: Chrome 68.0
• Steeditor.app at rev. 6911916

---

However, in the context of Hivemind communities, applying the same rules as for account names is a reasonable choice as pointed out by @jakipatryk. The previous rule with lower-case chars only was, nevertheless, too strict for that requirement. In the discussion, it turned out that the previous account name validation rules also did not cover all cases.

@jakipatryk has changed to validation rule for the community field to the same rule as for account names and has extended the account name validation rules to the same set of rules applied by Condenser, SteemConnect and others.

GitHub Account

https://github.com/crokkon