Beem: discussions may fail to handle empty responses correctly

Project Information

• Repository: https://github.com/holgern/beem
• Project Name: Beem
• Publisher: @holger80

A GitHub issue as well as a PR to fix it were created. The PR was accepted/merged by the PO and will be part of the next beem release.

• https://github.com/holgern/beem/issues/54
• https://github.com/holgern/beem/pull/55

Expected behavior

discussions.Discussions_by_feed() should return an account's feed entries. If the account doesn't follow any other account, the result should be empty.

Actual behavior

discussions.Discussions_by_feed() returns an account's feed entries if there are entries available. If there are no entries available, beem iterates over all nodes and fails to return an empty result.

How to reproduce

from beem.discussions import Discussions_by_feed, Query
from beem.account import Account
account = Account('stmdev')
query = Query(limit=20, tag=account['name'])
for entry in Discussions_by_feed(query):
    print(entry)

Result:

Error: Empty Reply
Lost connection or internal error on node: wss://steemd.minnowsupportproject.org (1/-1) 

Error: Empty Reply
Lost connection or internal error on node: wss://rpc.steemviz.com (1/-1) 

Error: Empty Reply
Lost connection or internal error on node: wss://rpc.buildteam.io (1/-1) 

Error: Empty Reply
Lost connection or internal error on node: wss://steemd.privex.io (1/-1) 

Error: Empty Reply
Lost connection or internal error on node: https://api.steemit.com (1/-1) 

Error: Empty Reply
Lost connection or internal error on node: https://rpc.buildteam.io (1/-1) 

Error: Empty Reply
Lost connection or internal error on node: https://rpc.steemviz.com (1/-1) 
...

The reason is that beem by default switches to the next node if an RPC reply is empty. However, an empty reply is the correct reply in this case. Some classes in beem.discussions are missing the corresponding code to handle this situation:

        self.steem.rpc.set_next_node_on_empty_reply(self.steem.rpc.get_use_appbase())

Environment

• beem master at rev. aa74d03
• python 3.6.5

GitHub Account

https://github.com/crokkon