Koler V0.2.7 Crashes When A Number Is Pressed While On A Call

in #utopian-io5 years ago

Repository: https://github.com/Chooloo/call_manage
Project Name: Koler
Issue Acknowledged & Fixed: https://github.com/Chooloo/call_manage/issues/4

Expected behavior

I expected Koler not to crash when a user types a number while dialing a call.

Actual behavior

It crashes immediately after pressing the first number.

How to reproduce

  • dial a number
    ( mute, pause, loudspeaker, an option to dial a number, and a + sign button will pop up.)

  • Click on the option to dial a number

  • Type a number

  • Watch the app crash

  • Browser/App version:
    Koler v0.27

  • Operating system:
    Android 0

Recording Of The Bug

MNML-May15-1145-1557917215368.gif

Here's the Crash Log

    Process: com.chooloo.www.callmanager, PID: 31209
    java.lang.NullPointerException: Attempt to invoke virtual method 'void android.telecom.Call.playDtmfTone(char)' on a null object reference
        at com.chooloo.www.callmanager.util.CallManager.keypad(CallManager.java:108)
        at com.chooloo.www.callmanager.ui.activity.OngoingCallActivity.lambda$onCreate$2(OngoingCallActivity.java:304)
        at com.chooloo.www.callmanager.ui.activity.-$$Lambda$OngoingCallActivity$iL9ptpUuP7OEHn93SAfMj0buAE0.onChanged(Unknown Source:2)
        at androidx.lifecycle.LiveData.considerNotify(LiveData.java:113)
        at androidx.lifecycle.LiveData.dispatchingValue(LiveData.java:131)
        at androidx.lifecycle.LiveData.setValue(LiveData.java:289)
        at androidx.lifecycle.MutableLiveData.setValue(MutableLiveData.java:33)
        at com.chooloo.www.callmanager.viewmodels.SharedDialViewModel.setNumber(SharedDialViewModel.java:32)
        at com.chooloo.www.callmanager.ui.fragment.DialerFragment.setNumber(DialerFragment.java:220)
        at com.chooloo.www.callmanager.ui.fragment.DialerFragment.addChar(DialerFragment.java:120)
        at com.chooloo.www.callmanager.ui.fragment.DialerFragment_ViewBinding$11.doClick(DialerFragment_ViewBinding.java:137)
        at butterknife.internal.DebouncingOnClickListener.onClick(DebouncingOnClickListener.java:18)
        at android.view.View.performClick(View.java:6748)
        at android.view.View$PerformClick.run(View.java:25458)
        at android.os.Handler.handleCallback(Handler.java:790)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6524)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:888)

My Github Account

Realrufans

Sort:  

Nice work noticing the bug @rufans. I can see that the issue is now closed and fixed by the PO. Looks like a nice find.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Thank you for your review, @knowledges! Keep up the good work!

Hi @rufans!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server

Hey, @rufans!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Coin Marketplace

STEEM 0.25
TRX 0.11
JST 0.029
BTC 69428.61
ETH 3688.87
USDT 1.00
SBD 3.36