Minecolonies & A Bunch of Fixes

Hi everyone, I was traveling the last week so I was unable to post anything here. Nonetheless, before I went traveling I merged a bunch of pull requests which I'll be able to write about over the next days.

First of all, I had fixed a bunch of small problems before heading to the holidays.

First batch:

The first fix I did was related to a series of index out of range exceptions which filled up the log. I now made sure that null is returned when out of range so the workers can do the appropriate actions to recover from this situation.

Then, I had profiled our server to find out what is influencing the performance and I found out that we were wasting 10% of the performance on the building task manager. So I made sure it doesn't get called every tick but every second on average.

After that, I did some renaming to have variable names which make sense

and fixed the tinkers mod compatibility by calculating the weapon strength when the weapon is searched so the worker actually uses it.

Following that, I found out that the deliveryman was calculating chests with enough space wrong since it checked for the max stack size of 64 for each stack although some items cannot be stacked up to 64.

Second Batch:

In the second batch, I fixed the claim command to take the dimension into account which is getting claimed by the player while also allowing to unclaim area which does not belong to any valid colony anymore. For that I made the colony id input an integer and added an integer for the dimension.

Then I obtain the id and dimension and claim the chunks based on that.

After that, I got contacted that the sandstone barracks offset is wrong. When I checked the code I noticed that the barracks need an offset into the other direction for sandstone.

Then, after the pvp-event I had noticed that having guards on follow is a pain because they don't walk very fast, as a fix I added that after a certain distance to the player they will teleport to the player.

Then, I fixed a crash with citizens trying to access their bed wrong and improved the performance of the call.

Third Batch:

In the third batch, I first fixed an issue where the world crashed because of the huge pathfinding range of certain workers. I quickly found out that this was related to some workers trying to path to the origin block in certain moments since their actual target was not correctly set yet. To avoid this I added a check to the base method.

After that, I figured out why the builder was running to empty chests since he was picking up air.

And finally, I fixed some issues with the miner related to chunk un/reloading. By reloading the structure the miner is working on if he doesn't have any.

Almost forgot, I also added support for other chests over a certain size for the workers to access by filtering them based on the minimum size to avoid detecting furnaces and similar.

Repository:

https://github.com/ldtteam/minecolonies

https://github.com/ldtteam/minecolonies/pull/2917
https://github.com/ldtteam/minecolonies/pull/2920
https://github.com/ldtteam/minecolonies/pull/2913
https://github.com/ldtteam/minecolonies/pull/2911
https://github.com/ldtteam/minecolonies/pull/2870
https://github.com/ldtteam/minecolonies/pull/2874