Steemnova - Fixed language issues on friend requests

in #utopian-io • 6 years ago (edited)

Bug Fix

What was the issue?

There were issues in steemnova while sending/deleting/accepting friendrequests, if the language of the two users are different.

image.png

For more details please see my bugreport about this issue.

Related issue on Github

What was the solution?

As seen in the screenshot the variable language was not defined.
This was the case everytime the language of the user and that of the "friend" were different.

So to fix the bug I searched the "ShowBuddyListPage" for all occurences of the language variable. I then replaced them with the correct language.

image.png

image.png

image.png

As you can see the language of the current user is always in $USER['lang']. It is compared to the language of the other user, if they are different the language of the other user should be used. This is because it determines the language of the message that is send to the other user.
As you can see the language of the other user is in the variables "$row['lang']", "$requestData['lang']" and "$sender['lang']" respectively.

My PullRequest


Posted on Utopian.io - Rewarding Open Source Contributors

#steemnova #bugfix #friendrequest #steemdev
6 years ago in #utopian-io by
$90.90
  • Past Payouts $90.90, 0.00 TRX
  • - Author $63.56, 0.00 TRX
  • - Curators $27.34, 0.00 TRX
36 votes
Reply 4
Sort:  
  • Trending
    • [-]
     6 years ago 

    Thank you for the contribution. It has been approved.

    You can contact us on Discord.
    [utopian-moderator]

    $0.04
    • Past Payouts $0.04, 0.00 TRX
    • - Author $0.03, 0.00 TRX
    • - Curators $0.01, 0.00 TRX
    1 vote
    Reply
    [-]
     6 years ago 

    Thanks Vlad! :)

    $0.00
      Reply
      [-]
       6 years ago 

      Congratulations! This post has been upvoted from the communal account, @minnowsupport, by MWFIAE from the Minnow Support Project. It's a witness project run by aggroed, ausbitbank, teamsteem, theprophet0, someguy123, neoxian, followbtcnews, and netuoso. The goal is to help Steemit grow by supporting Minnows. Please find us at the Peace, Abundance, and Liberty Network (PALnet) Discord Channel. It's a completely public and open space to all members of the Steemit community who voluntarily choose to be there.

      If you would like to delegate to the Minnow Support Project you can do so by clicking on the following links: 50SP, 100SP, 250SP, 500SP, 1000SP, 5000SP.
      Be sure to leave at least 50SP undelegated on your account.

      $0.00
        Reply
        [-]
         6 years ago 

        Hey @mwfiae I am @utopian-io. I have just upvoted you!

        Achievements

        • You have less than 500 followers. Just gave you a gift to help you succeed!
        • Seems like you contribute quite often. AMAZING!

        Community-Driven Witness!

        I am the first and only Steem Community-Driven Witness. Participate on Discord. Lets GROW TOGETHER!

        mooncryption-utopian-witness-gif

        Up-vote this comment to grow my power and help Open Source contributions like this one. Want to chat? Join me on Discord https://discord.gg/Pc8HG9x

        $0.00
          Reply

          Coin Marketplace

          STEEM 0.19
          TRX 0.13
          JST 0.030
          BTC 63574.15
          ETH 3404.81
          USDT 1.00
          SBD 2.54