(Nearby-Shops-End-User-Android-app V 1.1) app crash when try to create a new market if we cancel and try to type a new url

in #utopian-io5 years ago

PROJECT INFORMATION

REPOSITORIES :https://github.com/SumeetMoray/Nearby-Shops-Admin-App OR CAN BE https://github.com/SumeetMoray/Nearby-Shops-End-User-Android-app
ISSUES : https://github.com/SumeetMoray/Nearby-Shops-Admin-App/issues/2

EXPECTED BEHAVIOR

when writing the url that you want to submit the user should be able to cancel the creation of a new market so that users can submit a new url for the local market

ACTUAL BEHAVIOR

after the user cancels the creation of a new market then when the user wants to write the new url this application will crash

STEP TO REPRODUCE

  • install and open the app
  • scroll right to the "market" section
  • there will be a "+" button, press the button and write a url
  • press submit, then wait a few seconds, then press any part of the screen to cancel creating a new market.
  • theN try to write a new url and note the error

ERROR RECORDING

android: android 6.1
BROWSER: Nearby-Shops-End-User-Android-app V 1.1

Process: org.nearbyshops.enduserappnew, PID: 17603
java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.res.Resources android.content.Context.getResources()' on a null object reference
    at android.widget.Toast.<init>(Toast.java:106)
    at android.widget.Toast.makeText(Toast.java:271)
    at org.nearbyshops.enduserappnew.Markets.SubmitURLDialog.showToastMessage(SubmitURLDialog.java:218)
    at org.nearbyshops.enduserappnew.Markets.SubmitURLDialog$1.onFailure(SubmitURLDialog.java:207)
    at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall$1$2.run(ExecutorCallAdapterFactory.java:80)
    at android.os.Handler.handleCallback(Handler.java:815)
    at android.os.Handler.dispatchMessage(Handler.java:104)
    at android.os.Looper.loop(Looper.java:218)
    at android.app.ActivityThread.main(ActivityThread.java:5657)
    at java.lang.reflect.Method.invoke(Native Method)
    at java.lang.reflect.Method.invoke(Method.java:372)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:990)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:785)```
Sort:  

Hi @muhammadarif, thanks for making this contribution

The log provided is not as precise and should be supported with a detailed explanation. I can see the PO after a careful observation, has acknowledged and fixed the issue in this commit - https://github.com/SumeetMoray/Nearby-Shops-End-User-Android-app/commit/c03999303f7742e4f5f9fc947c1c569dd53825b4

He also pointed the correct repo to be this https://github.com/SumeetMoray/Nearby-Shops-End-User-Android-app and not that in which the ticket was opened. Please make sure to always confirm the authenticity of a repo before opening an issue.

Good of you to have shared this. I look forward to more of your reports.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Thank you for your review, @fego! Keep up the good work!

Hi @muhammadarif!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server

Hey, @muhammadarif!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Hi, @muhammadarif!

You just got a 0.05% upvote from SteemPlus!
To get higher upvotes, earn more SteemPlus Points (SPP). On your Steemit wallet, check your SPP balance and click on "How to earn SPP?" to find out all the ways to earn.
If you're not using SteemPlus yet, please check our last posts in here to see the many ways in which SteemPlus can improve your Steem experience on Steemit and Busy.

Coin Marketplace

STEEM 0.26
TRX 0.14
JST 0.034
BTC 59038.81
ETH 3298.80
USDT 1.00
SBD 4.21