family finance (v1.55) app crash when change view by in report section

in #utopian-io5 years ago

PROJECT INFORMATION

EXPECTED BEHAVIOR

when the user changes the appearance of the report from "view value" to "use percent value" this application will still work properly and will display report data in accordance with the wishes of the user

ACTUAL BEHAVIOR

when the user changes the appearance of the report from "view value" to "use percent value" this application will crash and stop working

STEPS TO REPRODUCE

  • install and open the app
  • click "report" option
  • scroll to the right side to "incomes by articles or expenses by articles
  • click eye icon
  • change view by "view values" to "use percent values"
  • see errors
    devices
  • phone models: oppo neo 7
  • os : android 6.1

BUG RECORDING


logcat

Process: io.github.zwieback.familyfinance, PID: 13191
java.lang.NullPointerException: Attempt to invoke virtual method 'void com.github.mikephil.charting.data.PieData.setDrawValues(boolean)' on a null object reference
    at io.github.zwieback.familyfinance.business.chart.fragment.PieChartFragment.onApplyDisplay(PieChartFragment.java:160)
    at io.github.zwieback.familyfinance.business.chart.fragment.PieChartFragment.onApplyDisplay(PieChartFragment.java:40)
    at io.github.zwieback.familyfinance.business.chart.activity.ChartActivity.onApplyDisplay(ChartActivity.java:150)
    at io.github.zwieback.familyfinance.business.chart.dialog.ChartDisplayDialog.lambda$onCreateDialog$0(ChartDisplayDialog.java:53)
    at io.github.zwieback.familyfinance.business.chart.dialog.-$$Lambda$ChartDisplayDialog$3JuCWsAV3m9zaJu55iVYBsSndyU.onClick(lambda)
    at android.support.v7.app.AlertController$ButtonHandler.handleMessage(AlertController.java:167)
    at android.os.Handler.dispatchMessage(Handler.java:111)
    at android.os.Looper.loop(Looper.java:218)
    at android.app.ActivityThread.main(ActivityThread.java:5657)
    at java.lang.reflect.Method.invoke(Native Method)
    at java.lang.reflect.Method.invoke(Method.java:372)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:990)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:785)```
Sort:  

Hi @muhammadarif, thanks for making this contribution.

I can see this has been acknowledged and fixed by the PO in this commit - https://github.com/zwieback/FamilyFinance/commit/4d1e8446b45d0e425d321255ccf61ec028d6ebd6. The crash report you provided was really helpful. I can see that the PO appreciated the effort.

I look forward to more of your reports.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Thank you for your review, @fego! Keep up the good work!

Congratulations @muhammadarif !
🚀 🌕 You WON the Player’s Upvote Lottery for playing moonSTEEM
Here's a 100% Upvote for you ! May the Moon be with you !

Moon your steem everyday ! Instant Dividend payout after every game - moonSTEEM.com

Hi @muhammadarif!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server

Hey, @muhammadarif!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Hi, @muhammadarif!

You just got a 0.05% upvote from SteemPlus!
To get higher upvotes, earn more SteemPlus Points (SPP). On your Steemit wallet, check your SPP balance and click on "How to earn SPP?" to find out all the ways to earn.
If you're not using SteemPlus yet, please check our last posts in here to see the many ways in which SteemPlus can improve your Steem experience on Steemit and Busy.

Congratulations @muhammadarif! You have completed the following achievement on the Steem blockchain and have been rewarded with new badge(s) :

You received more than 500 as payout for your posts. Your next target is to reach a total payout of 1000

You can view your badges on your Steem Board and compare to others on the Steem Ranking
If you no longer want to receive notifications, reply to this comment with the word STOP

Vote for @Steemitboard as a witness to get one more award and increased upvotes!

Coin Marketplace

STEEM 0.25
TRX 0.14
JST 0.033
BTC 51680.15
ETH 3035.28
USDT 1.00
SBD 4.21