[busy.org] Re-write bug for curation-rewards and author-rewards link
Project Information
- Repository: https://github.com/busyorg/busy
- Project Name: busy.org
- Version: 2.5.6
Expected behavior
When re-write link feature is enable in busy settings, only valid busy links should get changed from steemit.com to busy.org.
Actual behavior
Some of steemit.com links show page not found when re-written as busy.org.
How to reproduce
(1) Create a post with following valid steemit.com link:
- Curation Rewards - https://steemit.com/@mightypanda/curation-rewards
- Author Rewards - https://steemit.com/@mightypanda/author-rewards
(2) Go into Settings page on busy.org and enable Re-write links
(3) Go to the post that you created with the steem link and click on the links. You will be redirected to "Page Not Found"
Example Post to reproduce the bug
https://busy.org/@fastandcurious/testing-some-issue-don-t-mind-me
- Browser: Chrome Version 69.0.3497.100 (Official Build) (64-bit)
- Operating system: OSX 10.11.6
GitHub Account: https://github.com/mightypanda-x
Issue: https://github.com/busyorg/busy/issues/2125
HI @mightypanda, thanks for making this contribution.
While the behavior can easily be replicated, it does not pass as a bug. Reason being that there is no direct link on the busy.org frontend to access the affected pages - (curation-rewards and author-rewards).
On the steemit front end, the curation-rewards page can be accessed by simpy typing https://steemit.com/@mightypanda/curation-rewards in your browser, while on the busy frontend you'll have to open the activity tab and then check the curation rewards box to filter out the curation rewards from a list of other activities, same with author rewards.
On busy, there is no dedicated page for any of the above, this is the same for recent-replies. Typing https://busy.org/@mightypanda/recent-replies in your browser returns a "No page found" error while this loads on steemit.
We can say this is an unimplemented feature since it works for pages that are properly linked.
Thanks again for the contribution. I look forward to your next bug report
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Hi @fego,
When thr is no such link on busy, it should not convert it. There was a similar bug identified, acknowledged and fixed by busy team in may.
https://github.com/busyorg/busy/issues/1900
They missed these links while doing this fix.
Also, link to replies on busy: https://busy.org/replies
Atleast for the logged in user
The contributor in the ticket attested this to be a rare case.
And like you've pointed out, the above links were not included in the list of links that were not to be rewritten.
It becomes a bug when it is included and still gets rewritten. Then we would say the code is faulty.
Honestly, I don't see the difference between two issues here:
Bug 1900 said that there is no market link on busy so it should not get re-written. And they fixed that particular issue.
My bug says curation rewards and replies should not get re-written with busy url. Its the same bug for different url. So if that was a bug, this should be too.
@sachincool Maybe you can tell me what I am missing here.
Thank you for your review, @fego! Keep up the good work!
Hi, @mightypanda!
You just got a 5.25% upvote from SteemPlus!
To get higher upvotes, earn more SteemPlus Points (SPP). On your Steemit wallet, check your SPP balance and click on "How to earn SPP?" to find out all the ways to earn.
If you're not using SteemPlus yet, please check our last posts in here to see the many ways in which SteemPlus can improve your Steem experience on Steemit and Busy.
Congratulations! This post has been upvoted from the communal account, @minnowsupport, by mightyPanda from the Minnow Support Project. It's a witness project run by aggroed, ausbitbank, teamsteem, someguy123, neoxian, followbtcnews, and netuoso. The goal is to help Steemit grow by supporting Minnows. Please find us at the Peace, Abundance, and Liberty Network (PALnet) Discord Channel. It's a completely public and open space to all members of the Steemit community who voluntarily choose to be there.
If you would like to delegate to the Minnow Support Project you can do so by clicking on the following links: 50SP, 100SP, 250SP, 500SP, 1000SP, 5000SP.
Be sure to leave at least 50SP undelegated on your account.