You are viewing a single comment's thread from:
RE: Steem Apps Discord Bot - Utopian-io Submission
Thank you for your contribution @petertag !
- The PR has been outside the 14-day window - but you 've made some great work here, so I'd give a few comments.
- a few screenshots on discord could be useful for readers to understand how the bot actually works
type == 4,type > 1- magic numbers, could be replaced with meaningful names.- I'd expect to see some tests here using e.g.
mochaorchai, and you could also set up a CI on https://travis-ci.com - could
msg.contentbe null? should there be a null check? Also, you may use a regexp here e.g. `/^[!$].*/ to make your code look nicer. - For background discord bots, you may want to log to files instead of
console.log if (args && Array.isArray(args)) {is theArray.isArray(args)sufficient enough?color: 12607945etc could be customized by moving it to a external json config.- Are you sure that in
qs[qs.length - 2],qsis at least 2 elements?
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Thanks for the quick response justyy! I figured there would be something like that, just wanted to get this post up before the final-ish PR was accepted. I'll include some more screenshots for usage on the next one, as I don't think the bot is active yet and this PR didn't contain most of the currently working parameters.
I'll add in const declarations in the config, I'll probably keep it in the same file as the bot token, will throw the color in there as well.
Honestly wasn't sure if/how to test a Discord bot, used travis-ci before though, I'll check out
mochaorchaiWill add a null check in, missed that, assumed the msg wouldn't show up without content when first setting it up, but realize now that embeds can work without.
True, most of the logs were error checking, the login one I thought was important but you can see the bot is online in Discord anyways.
I believe it is, went over a few stackoverflow answers to ensure errors weren't thrown but it also fully checks.
It is, due to the parseArgs pushing in default arguments for sort type, time, and sort order if they are not passed in, but I should probably make that more clear somewhere.
Cheers!
Thank you for your review, @justyy! Keep up the good work!