You are viewing a single comment's thread from:
RE: [KnackSteem API] - Delegators tokens distribution bot + Curation bot (voting + commenting + KNT distribution)
Thank you very much for your contribution @jaysermendez !
- it might be better to have delegations data obtained from blockchain instead of being hard-coded in
delegations.json. This does not need to be at real time - I think you can do this in a separate process running at background periodically. Or, you can use @steemsql - IMHO, i am not a big fan of posting templated comments on blockchain. It is kinda of spam - and it costs RC. You might want to introduce mechanisim to control the frequency of posting.
- Do you really want to check-in the
yarn.lockaccording to this?
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Hello @justyy,
Thanks for the suggestions. I didn't realize about the yarn.lock being committed. Will surely remove it.
Regarding delegations.json, this is not hardcoded. It is served as a baseline for seeding purposes and it is patched with deltas thereafter. Before each distribution, it is patched with the latest data.
Regarding the comment template, @knowledges what do you think?
The comment is made under each approved and scored knacksteem post. Very similar to what Utopian and other similar projects on the blockchain does. I don't consider this as spamming.
As for the delegation.json, it may look hard-coded but its not. It serves only as a baseline for seeding as explained by @jaysermendez
Here is the sync script :) https://github.com/knacksteem/knacksteem-api/blob/master/src/api/pollers/delegators.poller.js
Thanks. In this case you might not want to check in this file ‘delegation.json’ as well. ;)
Posted using Partiko iOS
Thank you for your review, @justyy! Keep up the good work!