Thank you for your contribution. The idea is great but the code could be much improved especially there are quite alot of code smells:
- hard code the
rocksciss
in here - still using
document.getElementById
nowadays. - inconsistent code formatting/indent.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Hey @justyy
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.
Contributing on Utopian
Learn how to contribute on our website.
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!
@justyy, thank you very much for your review.
What I understand from your comments, I killed a good idea with my amateurish coding ;)
Hardcode, yes there is...there are much more pro ways to do this and l will be learning by doing and these kinds of feedbacks are very important on my way.
document.getElementById
is how I started learning ( l blame freecodecamp for this lol ) and learned the$("#id").append
on the way but still using the first one if the text is not too much. Your comment noted. I am coming from Commodore 64 times btw ;)Inconsistent code formatting - another good critic. Noted.
FD.