You are viewing a single comment's thread from:

RE: Steem Voice A0.5 - Migration to Google V2 API

in #utopian-io6 years ago

Thank you for your contribution. This is defintely a unique piece of work.

  1. It is in general a good practise to submit your changes in a separate branch, create a PR and merge it - so you have a much cleaner commit logs in your master branch - and also it is easier to revert a set of changes if you decide to later.
  2. It will be a good idea to extract the set of commands such as ask('Would you like to confirm this upvote: %s... and put them in a separate class, file or module, so that it will be easier to maintain.
  3. I notice that the Google assistant is slightly laggy, any reasons/causes?
  4. Also, you are using general exception e.g. try .. catch for some known issues, such as user not registered. General Exception is bad.

Looking forward to your next contribution!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you for your review, @justyy! Keep up the good work!

Coin Marketplace

STEEM 0.18
TRX 0.14
JST 0.030
BTC 58679.35
ETH 3155.04
USDT 1.00
SBD 2.44