You are viewing a single comment's thread from:

RE: [New Features on steemr] supports AppBase API and plots active hour diagrams!

in #utopian-io6 years ago (edited)

Thank you for your contribution.

  • I will not suggest adding code that use steemdata because it just doesn't work, I don't think dead code should be in the code repro for any reasons.
  • While you start building the library, I would suggest you should also start adding unit tests, which gives the confidence while you make changes.
  • the code is not very much commented and I have seen the commented-out code as well.
  • You shouldn't set default parameters e.g. something like id='dapeng', if the id is not given, you should expect the function to throw exception
  • the database URI should be defined as a constant but should not appear in your code base more than once.
  • Your hourrose method, as you said you make some changes from the original copy, it will be better to provide the reference to the original code. And BTW, there are more than 400 lines of code for this function, which is un-maintainable.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

These are very useful suggestions for a non-professional programmer like me. Many thanks.

Regarding SteemData, I wish it could come back someday, as it is open source and anyone might take it over. I would leave the option there (perhaps commented out) for future use. It is just ten lines.

Ask @surfyogi if he can bring back a WORKING version of steemdata or something like it.

hey nice post! I have to admit I can'[t understand it but when i saw this post in a list of non technical posts on #promo-steem trending i realized i must upvote AND resteem this post to help promotoe technical steem posts. They help stimulate interest in programming which we all need to learn more about, or at least data

i mean what is an R environment? What is CRAN? What are those crazy maps u are showing that look like radar? Whats going on ?

Thank you very much for your kind support!

R is a programming language and free software environment for statistical computing and graphics. CRAN is the abbreviation for Comprehensive R Archive Network. More details can be found on Wikipedia. The radar map is a 24-hour clock, showing the active hours of a Steemian: the greater the radius is, the more posts the steemian has.

A tutorial to steemr might be useful and helpful. I will write one as soon as I finish the development of the main functions in steemr.

Hey @justyy
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.

Contributing on Utopian
Learn how to contribute on our website.

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Coin Marketplace

STEEM 0.18
TRX 0.16
JST 0.029
BTC 61081.21
ETH 2406.76
USDT 1.00
SBD 2.64