You are viewing a single comment's thread from:

RE: [ E-learning Js 0.1 ] Release 0.1.3 - alpha 1

in #utopian-io6 years ago (edited)

Thank you for your contribution.

  1. magik numbers such as tempPage <= 9
  2. You might want to let users define these data in a JSON/XML instead of main.js
  3. you probably could use some librarys/frameworks to make your Javascript code such as document.getQuerySelector or .style.display= shorter.
  4. some code duplications (could be refactored) for example:
const questionsHtml = document.querySelector(options.questionsHtml);
const resetButton = document.querySelector(options.resetButton);
...

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thanks @justyy for your recomendations, I will take this improvements in the project dashboard in github.

Thank you for your review, @justyy! Keep up the good work!

Coin Marketplace

STEEM 0.17
TRX 0.15
JST 0.029
BTC 60773.82
ETH 2378.63
USDT 1.00
SBD 2.57