You are viewing a single comment's thread from:

RE: SteemRecovery - A Python CLI to recover Steem accounts

in #utopian-io6 years ago

Thank you for your contribution. I am sure this will help many steemians recover their account.

  1. As I can see all the features are implemented in one single file, which is not easy to maintain and scale - you might want to break into modules.
  2. No unit tests
  3. Your functions like stop_powerdown, remove_withdraw_vesting_routes directly depend on getpass which relies on the user input. This is not a good design as it is not easily unit test-able. Instead, you might want to pass password i.e. getpass so that you can test those functions.
  4. account.replace("@", "") appears many many times - which should be extracted - avoid duplicate code, even it is one-line.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you for your review, @justyy! Keep up the good work!

Coin Marketplace

STEEM 0.19
TRX 0.14
JST 0.030
BTC 59715.05
ETH 3186.24
USDT 1.00
SBD 2.42