You are viewing a single comment's thread from:
RE: SteemRecovery - A Python CLI to recover Steem accounts
Thank you for your contribution. I am sure this will help many steemians recover their account.
- As I can see all the features are implemented in one single file, which is not easy to maintain and scale - you might want to break into modules.
- No unit tests
- Your functions like
stop_powerdown
,remove_withdraw_vesting_routes
directly depend ongetpass
which relies on the user input. This is not a good design as it is not easily unit test-able. Instead, you might want to passpassword
i.e.getpass
so that you can test those functions. account.replace("@", "")
appears many many times - which should be extracted - avoid duplicate code, even it is one-line.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @justyy! Keep up the good work!