You are viewing a single comment's thread from:

RE: Adonis-Auth-Scaffold Development Update: Api/HTTP Client Authentication Code Generation

in #utopian-io6 years ago

Thank you for your contribution.

You probably can use a single variable mode (which can be enum) to determine if it is API or REST, which will make the logics a lot simpler.

The copyAppStarterFiles appears to me requiring a parameter client, but on the code, it passes nothing, do this code work?

For the line append/prepend, have you considered the line endings on Linux, Windows or MAC? \n, \n\r or \r?

You may want to check if a file has been prepended using a better approach rather than if (fileContents[lineNumber] === lineContent) return; .

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Great insight. The v1.1.1 fix will address these issues.

Thank you for your review, @justyy! Keep up the good work!

Coin Marketplace

STEEM 0.24
TRX 0.25
JST 0.039
BTC 93333.46
ETH 3336.69
USDT 1.00
SBD 3.26