RE: Adonis-Auth-Scaffold Development Update: Api/HTTP Client Authentication Code Generation
Thank you for your contribution.
You probably can use a single variable mode
(which can be enum) to determine if it is API or REST, which will make the logics a lot simpler.
The copyAppStarterFiles appears to me requiring a parameter client, but on the code, it passes nothing, do this code work?
For the line append/prepend, have you considered the line endings on Linux, Windows or MAC? \n
, \n\r
or \r
?
You may want to check if a file has been prepended using a better approach rather than if (fileContents[lineNumber] === lineContent) return;
.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Great insight. The v1.1.1 fix will address these issues.
Thank you for your review, @justyy! Keep up the good work!