You are viewing a single comment's thread from:
RE: EduSteem - Student Interaction
Thank you for your contribution.
- a huge commit with lots of files isn't a very good practise. You should try split the commits over a few small and meaningful ones.
- the javascript is very old fashion and not modern at all. For example,
XMLHttpRequestcould be just replaced with jQuery ajax calls - inconsistent code formatting. It is suggested to format your code before you commit in.
- You SQL is mixed with JS and I would suggest extracting the SQLs into a class and
[info[15], info[17], info[4], info[5], info[1], info[6], info[7], info[2], info[3], info[9], info[8], info[10], info[11], info[12], info[13], info[16], info[0]])this is really un-maintainable. - Your SQL
var dataSTR = "SELECT * FROM Lessons WHERE id ='" + useri + "' AND unitnumber =" + unitnumber + + "' AND nitnumber =" + unitnumber + " ORDER BY lessonNum ASC"is subject to SQL injection --- not safe at all.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Sort: Trending
[-]
bflanagin (65) 7 years ago
- Can't control the size of commits if I'm basing it on features being completed.
- I base my code on what is suggested in Qt's documents. I'll look into if I can "update" the calls but it doesn't matter to me as long as it works.
- fair point, though I make no promises
- skipping
- Only if you allow raw data into the inputs and don't validate it, and I do both.