You are viewing a single comment's thread from:

RE: EduSteem - Student Interaction

in #utopian-io7 years ago

Thank you for your contribution.

  1. a huge commit with lots of files isn't a very good practise. You should try split the commits over a few small and meaningful ones.
  2. the javascript is very old fashion and not modern at all. For example, XMLHttpRequest could be just replaced with jQuery ajax calls
  3. inconsistent code formatting. It is suggested to format your code before you commit in.
  4. You SQL is mixed with JS and I would suggest extracting the SQLs into a class and [info[15], info[17], info[4], info[5], info[1], info[6], info[7], info[2], info[3], info[9], info[8], info[10], info[11], info[12], info[13], info[16], info[0]]) this is really un-maintainable.
  5. Your SQL var dataSTR = "SELECT * FROM Lessons WHERE id ='" + useri + "' AND unitnumber =" + unitnumber + + "' AND nitnumber =" + unitnumber + " ORDER BY lessonNum ASC" is subject to SQL injection --- not safe at all.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  
  1. Can't control the size of commits if I'm basing it on features being completed.
  2. I base my code on what is suggested in Qt's documents. I'll look into if I can "update" the calls but it doesn't matter to me as long as it works.
  3. fair point, though I make no promises
  4. skipping
  5. Only if you allow raw data into the inputs and don't validate it, and I do both.

Coin Marketplace

STEEM 0.09
TRX 0.30
JST 0.034
BTC 114941.03
ETH 4160.03
USDT 1.00
SBD 0.62