You are viewing a single comment's thread from:

RE: [development] Running SteemPlus natively on Firefox

in #utopian-io • 6 years ago

Thank you very much for the contribution. I am sure this will benefit the Firefox users. From the code you have touched, I can see slightly a few code duplication, which can be refactored by extracting that to a function.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

6 years ago in #utopian-io by
$10.01
  • Past Payouts $10.01
  • - Author $7.64
  • - Curators $2.38
13 votes
Reply 2
Sort:  
  • Trending
    • [-]
     6 years ago 

    Thank you for your review, @justyy!

    So far this week you've reviewed 4 contributions. Keep up the good work!

    $0.02
    • Past Payouts $0.02
    • - Author $0.02
    • - Curators $0.00
    3 votes
    Reply
    [-]
     6 years ago 

    I haven't got much time to rewrite the whole block, and because I am not JavaScript or WebExtensions expert, I decided to concentrate on making the bug fix clear without additional refactoring.

    The particular thing what is needed for refactoring is understanding the difference between lastFocusedWindow and currentWindow flags when querying for tabs. Chrome current window docs mention that currentWindow is where the code is currently executing. I understand that when I click extension button on the toolbar, the code is executed in the window with the toolbar. Then I don't understand why lastFocusedWindowis being used.

    $0.00
      Reply

      Coin Marketplace

      STEEM 0.24
      TRX 0.21
      JST 0.036
      BTC 98303.59
      ETH 3438.02
      USDT 1.00
      SBD 3.35