You are viewing a single comment's thread from:

RE: Keychainify on direct access to a SteemConnect URL

in #utopian-io6 years ago

Thank you for your contribution!.

  1. L74 which could be refactored using Array.includes
  2. We probably can rewrite Promise as async/await see here
  3. I prefer string.includes over string.indexOf()===-1

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thanks @justyy
I prefer using indexOf() in cases like here for more compatibility. As for async/await, my function calls another one that uses callbacks so using Promises makes it easier for calling resolve/reject

Thank you for your review, @justyy! Keep up the good work!

Coin Marketplace

STEEM 0.10
TRX 0.32
JST 0.033
BTC 111347.20
ETH 4079.14
USDT 1.00
SBD 0.62