You are viewing a single comment's thread from:

RE: blokz/profile Announcement

in #utopian-io5 years ago

Thank you for your contribution. Interesting project!

  1. I believe you don't have to store node_modules in your repro
  2. You may use some JS librarys to produce a cleaner-code, for example, document.getElementById is a bit verbose, and if you use jQuery, it could be a lot simpler
  3. some code/functions e.g. showTab, nextPrev are move around the files with unnecessary excessive blank lines.
  4. You could put all your changes in a branch and create a PR for it, which will be easily tracked later.
  5. As you mentioned, you might want to add the feature to include the author's introduceyourself post in the profile.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thank you for taking the time to review my project.
I'm working on cleaning up all the code and removing unused bits the next couple days, along with removing that silly node_nodules folder, still figuring out git as I go, a chunk of code on the repo isn't even used, I gotta sweep my floors as they say.
I was planning on having a links section for authors to include some of their more meaningful posts, with it auto suggesting (or maybe pulling info from introduceyourself post if they had made one).
Thank you again for your time and feedback, means a lot to me.

Thank you for your review, @justyy! Keep up the good work!

Coin Marketplace

STEEM 0.29
TRX 0.12
JST 0.034
BTC 63578.68
ETH 3314.57
USDT 1.00
SBD 3.94