You are viewing a single comment's thread from:

RE: steemblog -- browsing your steem posts faster

in #utopian-io • 5 years ago

Thank you very much for your contribution. This is an excellent tool that I have been looking for for a while. I remember @dapeng has developed something similar, but he is a big fan of R.

Could you add me to the travis before I forget, so that I have my blog, if I understand it correctly?

Here are my a few cents of comments:

  1. you might provide a fall-over mechanism if current Node is offline.
  2. maybe we don't need the active key for just reading data.
  3. there are a few classes in collector.py. It is better to only define a class in one file
  4. the classes at blog/steem are very general-purpose, you might consider add this to beem as well :)
  5. Unit tests are missing
  6. For SEO purposes, you might want to add the canonical links.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

Need help? Chat with us on Discord.

[utopian-moderator]

5 years ago in #utopian-io by
$14.45
  • Past Payouts $14.45
  • - Author $10.97
  • - Curators $3.47
26 votes
Reply 2
Sort:  
  • Trending
    • [-]
     5 years ago (edited)

    thanks @justty (行长）,

    yes. @dapeng developed one R package or command for building blog with hugo I think, e.g. https://steemit.netlify.com/ . Comparing to @dapeng 's version, this one might provide a bit more advantage in user experience and more optimization in build efficiency to make the service scalable and open to everyone.

    I have added you into steemblog. Your home page is: https://steemblog.github.io/@justyy/

    Your kind comments are very practical and helpful. Thanks a lot. Some feedback here:

    1. I have setup a backup with Netlify actually, but GitHub pages fit the scenarios better. We may open another subdomain on github.io as a backup site.
    2. we actually didn't use any steem keys to fetch the data from steem. (the blockchain data are open :)) The file settings.py was copied from a previous project, but we didn't do code cleanup. We may need the posting keys later if we want to enable steemblog to write back into steem blockchain, and we can remove the active keys.
    3. Umm... I also thought about that earlier. I can do some refactor, or even generalize them and merge them into beem project.
    4. sure. I can refactor that module and send to holger for review whether it's necessary to include part of them into beem.
    5. sure. We will add unit tests.
    6. cool. I'll put that into the future plan.

    The above suggestions are logged as issues in the steemblog/blog project in order to track and schedule.

    $0.00
      Reply
      [-]
       5 years ago 

      Thank you for your review, @justyy! Keep up the good work!

      $0.00
        Reply

        Coin Marketplace

        STEEM 0.19
        TRX 0.18
        JST 0.034
        BTC 89118.52
        ETH 3131.33
        USDT 1.00
        SBD 2.76