You are viewing a single comment's thread from:

RE: TravelFeed Curation Post Helper

in #utopian-io5 years ago
  • This article feels more like a blog post. Include explanation of coding choices for a development post.
  • An invitation for others to contribute would be nice.
  • There are no comments in the code.
  • Days of the week should always be capitalised. It does seem here that it will be part of the title of the article but feels unfinished as the title would look like this: monday title - Weekly Round-Up #62
  • Dead code should be taken out.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thanks for the review! A few questions:

  • monday title is not the actual title but an example from the sample configuration file. We use our own configuration (see below) in production which does not belong in the repository, but I thought it would be better to provide an example configuration instead of having contributors figure out by themselves which structure the configuration file should be in. Should I leave out example configurations in future contributions?
    Screenshot 20190429 at 14.24.18.png
  • What does "coding choices" mean for a simple script like this? Should I explain why I chose beem over steempy or sqlalchemy over some lesser used alternative?
  • How detailed would you expect comments to be? In a relatively simple script like this using clearly understandable names, I personally find that more comments than necessary don't improve the ease of understanding the code.

Thank you for your review, @helo! Keep up the good work!

Coin Marketplace

STEEM 0.17
TRX 0.15
JST 0.028
BTC 59893.00
ETH 2414.92
USDT 1.00
SBD 2.43