You are viewing a single comment's thread from:
RE: [steem] 14 week powerdown bug fix
- Good contribution to the Steem core and fixing the code to support the intent of the smart contract.
- Article could have used an intro image and other images like in your git issue.
- Code has no comment unfortunately.
- Big congratulation on your persistence and getting code merged on Steem core repo.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Regarding the comments, it think he was following the style of the steem code. Normally you don't see comments there to explain few lines.
Hi @jga! Thank you for defending me! @helo, thank you for reviewing too!
I usually include that kind of justifying argument in dev post (as an external contributor, i believe i should follow the PO's practice.), but I forgot this time.
I also didn't spend much time on making the post more detailed, but it seems quite important :) Since it's quite rare to make a contribution to the core, I honestly expected more, but this became my first dev post that got lower vote than idea post. lol! While it might have been better to give a second chance to improve (by a comment before the official review), that's fine. I'm still happy with the merging. Thanks!
Thank you for your review, @helo! Keep up the good work!