Insteem v1.5.0; The app crashed when I scrolled on the comments/replies page.
Project Information
- Repository: https://github.com/hispeedimagins/steem
- Project Name: Insteem
Expected Behavior
I expected that I could scroll on the comments/replies page for as long as I wished.
Actual Behaviour
The app crashed while scrolling through the content of the page.
Steps to reproduce
After doing all the necessary things to get into the app;
- Access the options menu by clicking the 3 horizontal bar at the top left of the app.
- Click on "comments/replies"
- You can decide if you wish to scroll on the comments page or replies page. Any of them will produce same error.
- Scroll on the comments/replies page.
- Scroll until the error occurs.
Test Environment
Device: Redmi Note 5 Pro
OS: Android 8.1
Software version: Insteem v1.5.0
Screen recording
Logcat
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:557)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:823)
Caused by: java.lang.reflect.InvocationTargetException
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
... 1 more
Caused by: org.json.JSONException: Value {"error":{"code":-32000,"message":"get_discussions_by_comments() got an unexpected keyword argument 'tag' (hivemind-alpha)"}} at result of type org.json.JSONObject cannot be converted to JSONArray
at org.json.JSON.typeMismatch(JSON.java:100)
at org.json.JSONObject.getJSONArray(JSONObject.java:591)
at com.insteem.ipfreely.steem.HelperClasses.JsonRpcResultConversion.ParseJsonBlogMore(JsonRpcResultConversion.kt:228)
at com.insteem.ipfreely.steem.HelperClasses.JsonRpcResultConversion.ParseJsonBlogMore$default(JsonRpcResultConversion.kt:219)
at com.insteem.ipfreely.steem.CommentNotificationsSteemitFragment.addMoreItems(CommentNotificationsSteemitFragment.kt:375)
at com.insteem.ipfreely.steem.CommentNotificationsSteemitFragment$GetMoreItems$s$1.onResponse(CommentNotificationsSteemitFragment.kt:354)
at com.insteem.ipfreely.steem.CommentNotificationsSteemitFragment$GetMoreItems$s$1.onResponse(CommentNotificationsSteemitFragment.kt:37)
at com.android.volley.toolbox.JsonRequest.deliverResponse(JsonRequest.java:90)
at com.android.volley.ExecutorDelivery$ResponseDeliveryRunnable.run(ExecutorDelivery.java:102)
at android.os.Handler.handleCallback(Handler.java:794)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:176)
at android.app.ActivityThread.main(ActivityThread.java:6635)
... 3 more
Thanks for your contribution.
I was able to replicate the issue, nice work on reporting with a log-cat included.
I would recommend adding a link to your issue within your task as it makes it easier to review.
Overall the steps were clear and easy to understand, however, I would recommend phrasing your expected and actual behaviour slightly different, try to avoid using the first person in this area of the bug report. Very minor, but maybe a little help :)
Once again, thanks for your contribution.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @tobias-g! Keep up the good work!
Hey, @harry-heightz!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!
Hi @harry-heightz!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server