ACG-Player; Add an option to remove song from trashcan. Add a confirmation form when the delete option is used.

Repository

• https://github.com/AugustToko/ACG-Player
• Link to issue on Github

Components

On ACG-Player, when I delete a song from the trashcan it gets permanently deleted(not removed) from the trashcan.
I was testing the feature and I added some songs to the trashcan. I deleted the songs hoping to find them back on my song list but I didn't. This led me to think that I might have permanently deleted the song. If that's the case, then it isn't good at all.

Proposal Description

If using the delete option deletes the song from my storage directly, then there should be another option in the options menu. The option should be 'remove from trashcan'. Or, the delete button could still be maintained, but when it is clicked, there should be an option to delete the song permanently, or deleted from the trashcan.
For my next request; if the developer decides to go with my former suggest (ie adding a remove button), then I'm requesting that a 'confirmation request form' should be added when I use the delete option. It was weird that as soon as I clicked delete, the song just vanished. No form to ask if I truly wanted to delete the song or not.

Mockups / Examples

Currently on the app, when you open the options menu in the trash-can, there's no option to remove a song. There's only the delete option;

If my suggestion is implemented, the 'remove from trash-can' button will appear here;

Now, for the delete option. There's no confirmation before deleting a song. But here's a sample of how the form could look like;

Benefits

The benefits of the features I've suggested are quite evident in my build-up texts so far. But for emphasis, I'll list them again.

• Prior to my suggestion, there was no way to remove a song from the trashcan. The only way was to delete the song. Deleting the song also meant that I'll be losing the song permanently. But with the remove from trash-can option, I can easily remove songs from the trash-can without any hassle.
• Deleting a song on ACG-Player was done without any sort of confirmation from the end-user if that action was intentional. It meant that I could delete a song which I didn't want to(delete) by mistake. The confirmation form takes care of that unwanted action. It's like a fool's proof or mistake proof.

GitHub Account

https://github.com/HarryHeights