RE: SteemVBS Update - Add Followers, Following, MVests and More
I see that you continue to improve your lib! Awesome.
Let's go for the review (I'll review what I can because VBS is a language lost in time for me :p):
https://github.com/DoctorLai/steemvbs/commit/4e7b65a15f848d899615f0a6de78ef398a48a3f9#diff-a35605fdf07f7c547712a1270f3ba998R306 => I think the variable name
idis weird. With id I expect the value to be an integer or a chain that has no meaning. But in fact it's the steem account!https://github.com/DoctorLai/steemvbs/blob/30f2f191024bd6f2a885e83f6e5cab18a4982f95/lib/steem.vbs#L114 => Does explicit variable name costs money in VB? :D when I read
rhave no idea what will contain this var. You got a lot of variables that could have a more detailed name.https://github.com/DoctorLai/steemvbs/commit/20f6dd3a59b7004cfde966738d01e320c939c5c2#diff-56e84782d1b199f68d1feb9536548815R8 => what happens if everybody leaves you? The test fails but your code wasn't modified. May be you can try to find a better way to test this method. I don't have an idea right now though ha ha.
Good luck for the roadmap!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thanks for the review!
Hey @gregory.latinier
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.
Contributing on Utopian
Learn how to contribute on our website.
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!