RE: Steem Tool(1.1.9) : Change Design and Add User Shortcut Function
Another tool to help writers with theirs posts. It's always nice to help the one that are writing content for the blockchain.
Let's go for the review:
Your README.md is really great! Nice gifs to show the use of the project, how to install it, etc. Really clean.
++
is a bad practicehttps://github.com/steemhappyberrysboy/steem_design_tool/blob/0152096b5cf3aae4039731a45ba106fd922116ba/popup.html#L64 => Don't commit dead code bloody hell! This consumes network and processing power which consume electricity. Dead code kills the planet!
useless comment war!
you've got a few comments like that. They have no value.using semantic-ui is really cool. I tried this library once they got cool components.
https://github.com/steemhappyberrysboy/steem_design_tool/commit/4ede6135321db02c5a522c4a689c81cbf2373c9a#diff-d7716810d825f4b55d18727c3ccb24e6R8 => It's recommended to use
===
,!==
etcYou should bundle and uglify your JS for production.
You increment your package version for each improvements this is a good practice. You could go even further and tag it.
https://github.com/steemhappyberrysboy/steem_design_tool/commit/2f0a6f6534a9e1a651ad02fb464b627621534b5f#diff-f29080f4111158fb8a9018d26f7e603fR10 => You should
try/catch
because localStorage can be modified and people can tamper it.
You got a few mistakes / inconsistencies but honestly this is good.
Good luck on your roadmap!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Hey @gregory.latinier
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.
Contributing on Utopian
Learn how to contribute on our website.
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!
I will fix about it.
I learned a lot from you.
Thanks for your great comments..!!