RE: eduSteem developement update (Week 3b)
Two updates in a day! Someone wants some upvote :D
So this is bad =>
https://github.com/bflanagin/EduSteem/blob/3b7d3b4ca2071e2ab29c4ee5017cfb073ea70d7a/Desktop/General/general.js#L9 every time you want to load some data you try to create the corresponding table. You should have a script that initialize your database and may be populate it with some basic mandatory data (like categories, languages, whatever)
I've also noticed that you open a transaction for a SELECT operation. Transactions are opened in case a rollback is needed. Here since you simply select some data just opening a connection should be fine.
Improving the performance right now will save you later !
Try to split your pull requests. Adding features and fixing bugs should be in separated PR.
Otherwise same comments than in the previous review :)
Good luck for your next PR
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Heh, I'm just trying to stay on schedule. I don't see a function in qtquick-localstorage to let me just pull from it without opening a transaction. There is the ability to have read only transactions. That's the closest thing I see.