Witness Voting Page Improvements

Repository

https://github.com/steemit/condenser

Description of Problem

Original issue: https://github.com/steemit/condenser/issues/1610

Witness voting page did not display property after casting votes. The linked issue had a video demonstrating the problem, where it had a consistent reproduction of a case where the user unvoted a witness, but the vote remained on the page. Only when refreshing the page would it correctly disappear.

The Fix

Pull request: https://github.com/steemit/condenser/pull/2859

After a bunch of debugging, the cause was that the flow for the process of voting for witness involved the sequence:

1. Remove witness vote from local state, to reflect in browser immediately.
2. Broadcast vote to steem node.
3. If the broadcast failed, restore state to pre-vote state.

The problem was that as part of step (2) above, it did a re-fetch of the user, and my guess here is that the node had not reflected latest state, and returned the votes back with the witness still populated. The fix involves a re-ordering:

1. Broadcast vote to steem node. (Still do the fetch of the user from steem node).
2. On success, remove witness vote from local state to reflect in browser. On failure, restore state to pre-vote state.

Additional Changes

The fix also added spinners to indicate that the vote was in progress. This works in the top 50 list as well as in the write-in list, on adding the vote and on removing the vote.

Here's a sample:

(Yes, if you ever stumble upon my witness voting history, I've been repeatedly voting and unvoting the inactive witness while testing this out)

When you do write-ins, while it's in the progress of voting it will show up with a spinner. And when you deactivate a write-in, it will show a spinner and remove after the vote is cast.

GitHub Account

https://github.com/eonwarped