Unfamiliar custom json operations cause empty activity at Busy.org
Project Information
- Repository: https://github.com/busyorg/busy
- Project Name: Busy
- Publisher: Busy.org team
- Related Github issue: https://github.com/busyorg/busy/issues/1909
Expected behavior
STEEM blockchain lets accounts to push any type of JSON into custom_json operations. Activity page should show the operation's details.
Since it's impossible to pre-define the structure on this, visualization may be done via tables. (Or as a design decision, busy may ignore the unregistered CustomJSON operations.)
Actual behavior
Activity pages show the operation empty, fails to fill the row.
Example:
See related transaction. It happens any type of custom json except follow/unfollow/ignore/reblog.
How to reproduce
Push a CustomJSON operation to the blockchain. It shouldn't follow the conventions on known custom jsons. (follow/unfollow, mute, etc.)
You will the see the activity page shows a blank entry.
For the reference, here is a python script to reproduce the issue:
from steem import Steem
from steem.transactionbuilder import TransactionBuilder
from steembase import operations
s = Steem(nodes=["https://rpc.buildteam.io"],
keys=["active_wif"])
account = "emrebeyler"
ops = [
operations.CustomJson(**{
"from": account,
"id": "custom_id",
"json": [
'custom_action',
{
"custom_key": "custom_value",
}
],
"required_auths": [],
"required_posting_auths": [account, ],
}),
]
tb = TransactionBuilder()
tb.appendOps(ops)
tb.appendSigner(account, "posting")
tb.sign()
tb.broadcast()
- Browser/App version: Chrome Version 66.0.3359.181 (Official Build) (64-bit) on latest stable busy release
- Operating system: OSX Sierra
Proposed Solution
Bug triaged in the repository and assigned to me. I have proposed to ignore unfamiliar custom json types. @fabien recommended to show them anyway with the table view. I will also create a pull request fixing this soon.
Hi @emrebeyler, thanks for leaving us this report.
The steps to reproduce were clear and easy to follow. I must commend your effort at engaging the POs in a mutual discourse and also in the process proposing a fix. I saw you were assigned to take care of the fix, since it was your idea.
We hope your intended PR rectifies the issue and displays in the activity tab - the operation details in the proposed table.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thanks for the review, @fego. :)
Hey @emrebeyler
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!