RE: TurkishSuffix 0.3.1 - Major Vowel Exception and Rewrite
Great project.
ConfigLoader seems like a little bit off the hook. I would use a default settings file or class in the package then let the user override values instead of using a loader like this. Is there a specific reason for using a loader like this?
Also, When I install the package on a python3.6 environment, I got an error about the config. Here is the stack trace.
Steps to reproduce:
- create a python3.6 virtual environment
- install the package via pip
- open the Python repl
- try
from turkishsuffix import turkishSuffix.
Other than these, it looks like a great effort to a well known problem. Waiting to see it's progress.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thank you for the review. I did created the loader class for .ini files. There is no specific reason for it with .py file. So, you are right, its kinda overkill and unnecessary. I will remove it in the next version.
About the issue, I learned out I also have to add .py files in subdirectories to the MANIFEST file. So, in short, it wasn't including config directory. When I checked site-packages/turkishsuffix I found old config.ini there and got shocked. It was probably an artifact from older build folder. I did rebuild it with new MANIFEST file and checked dist\ folder before pushing it. It's working now. I wouldn't notice it without you, thank you.
Thank you for your review, @emrebeyler! Keep up the good work!
Commenting just to follow the convo..
And I'd like to learn any other suggestions for using/manipulating configs. I'm trying to build a script as well just for education purposes and I'm not sure what to use. I want to be able to change setting while script is running, so I know I need argparse and and edit the config file with parsed arguments and read the config file in an infinite while loop. I'm unsure if this is the effective way of doing this.