You are viewing a single comment's thread from:

RE: New Project - django_steemconnect , How to configure and use it with your django application.

in #utopian-io6 years ago (edited)

Great work.

  • Keeping the CLIENT on a mutable global state (module scope) is considered bad. Here is a good discussion about it.

  • It seems you break general convention on model naming (class naming in general) with the Steemconnect_Model. My humble advise removing the model from the name just use SteemConnectUser.

  • I see you set a random password for steem connect users. django.auth package has a set_unusable_password helper for that kind of stuff.

  • Using get_or_create, here help removing a couple of extra lines.

  • Having descriptive commit messages has a part on our scoring logic. A commit message with just "rename" doesn't make any sense to the other developers reading the git history.


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thanks for your advice and preview 👍, I will update this project with a new commit. 🤚

Hey @emrebeyler
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.

Contributing on Utopian
Learn how to contribute on our website.

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Coin Marketplace

STEEM 0.20
TRX 0.13
JST 0.029
BTC 67475.08
ETH 3475.54
USDT 1.00
SBD 2.65