You are viewing a single comment's thread from:

RE: Now Playing Network Replies Feature

in #utopian-io • 6 years ago

Thank you for your contribution.

  1. You were using array.forEach here https://github.com/alex-osman/nowplaying/commit/239f441831dac26d2205f0079e60bdfd83ee97b1#diff-7a4b922cffcef420a6101235ce72f371L98 and then changed to for loop is there any specific reason.

  2. It is better to remove console.log() messages and to use other means of testing
    https://github.com/alex-osman/nowplaying/commit/239f441831dac26d2205f0079e60bdfd83ee97b1#diff-7a4b922cffcef420a6101235ce72f371L141

  3. When you are parsing its better to write some details about it
    https://github.com/alex-osman/nowplaying/commit/239f441831dac26d2205f0079e60bdfd83ee97b1#diff-7a4b922cffcef420a6101235ce72f371R294

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

6 years ago in #utopian-io by
$0.00
    3 votes
    Reply 1
    Sort:  
  • Trending
    • [-]
     6 years ago 

    Thanks for reviewing @codingdefined. This is my first time contributing without the utopian.io website so I apologize if some things are not in the write place.

    In regards to your first point, I changed the forEach to a for loop because the for loop is synchronous, and because steem requires 20 seconds between posting, the async forEach was causing issues when having to comment on many people's posts. This deserves a comment!

    Good points with (2) and (3) and I will update those to be more clear. Thanks for taking the time to review this!

    Coin Marketplace

    STEEM 0.17
    TRX 0.16
    JST 0.028
    BTC 76457.44
    ETH 2977.83
    USDT 1.00
    SBD 2.62